Migrate codebase from CommonJS to ES Modules
- Convert all require()/module.exports to import/export across 260+ files - Add "type": "module" to package.json to enable ESM by default - Add migrations/package.json with "type": "commonjs" to keep db-migrate compatible - Convert eslint.config.js to ESM with sourceType: "module" - Replace __dirname/__filename with import.meta.dirname/import.meta.filename - Replace require.main === module with process.argv[1] === import.meta.filename - Remove 'use strict' directives (implicit in ESM) - Convert dynamic require() in switch statements to static import lookup maps (dns.js, domains.js, backupformats.js, backupsites.js, network.js) - Extract self-referencing exports.CONSTANT patterns into standalone const declarations (apps.js, services.js, locks.js, users.js, mail.js, etc.) - Lazify SERVICES object in services.js to avoid circular dependency TDZ issues - Add clearMailQueue() to mailer.js for ESM-safe queue clearing in tests - Add _setMockApp() to ldapserver.js for ESM-safe test mocking - Add _setMockResolve() wrapper to dig.js for ESM-safe DNS mocking in tests - Convert backupupload.js to use dynamic imports so --check exits before loading the module graph (which requires BOX_ENV) - Update check-install to use ESM import for infra_version.js - Convert scripts/ (hotfix, release, remote_hotfix.js, find-unused-translations) - All 1315 tests passing Migration stats (AI-assisted using Cursor with Claude): - Wall clock time: ~3-4 hours - Assistant completions: ~80-100 - Estimated token usage: ~1-2M tokens Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
+17
-7
@@ -1,13 +1,23 @@
|
||||
'use strict';
|
||||
import assert from 'node:assert';
|
||||
import constants from './constants.js';
|
||||
import dns from 'node:dns';
|
||||
|
||||
exports = module.exports = {
|
||||
resolve,
|
||||
let _mockResolve = null;
|
||||
|
||||
function _setMockResolve(fn) {
|
||||
_mockResolve = fn;
|
||||
}
|
||||
|
||||
function resolveWrapper(hostname, rrtype, options) {
|
||||
if (_mockResolve) return _mockResolve(hostname, rrtype, options);
|
||||
return resolve(hostname, rrtype, options);
|
||||
}
|
||||
|
||||
export {
|
||||
resolveWrapper as resolve,
|
||||
_setMockResolve,
|
||||
};
|
||||
|
||||
const assert = require('node:assert'),
|
||||
constants = require('./constants.js'),
|
||||
dns = require('node:dns');
|
||||
|
||||
// a note on TXT records. It doesn't have quotes ("") at the DNS level. Those quotes
|
||||
// are added for DNS server software to enclose spaces. Such quotes may also be returned
|
||||
// by the DNS REST API of some providers
|
||||
|
||||
Reference in New Issue
Block a user