Migrate codebase from CommonJS to ES Modules
- Convert all require()/module.exports to import/export across 260+ files - Add "type": "module" to package.json to enable ESM by default - Add migrations/package.json with "type": "commonjs" to keep db-migrate compatible - Convert eslint.config.js to ESM with sourceType: "module" - Replace __dirname/__filename with import.meta.dirname/import.meta.filename - Replace require.main === module with process.argv[1] === import.meta.filename - Remove 'use strict' directives (implicit in ESM) - Convert dynamic require() in switch statements to static import lookup maps (dns.js, domains.js, backupformats.js, backupsites.js, network.js) - Extract self-referencing exports.CONSTANT patterns into standalone const declarations (apps.js, services.js, locks.js, users.js, mail.js, etc.) - Lazify SERVICES object in services.js to avoid circular dependency TDZ issues - Add clearMailQueue() to mailer.js for ESM-safe queue clearing in tests - Add _setMockApp() to ldapserver.js for ESM-safe test mocking - Add _setMockResolve() wrapper to dig.js for ESM-safe DNS mocking in tests - Convert backupupload.js to use dynamic imports so --check exits before loading the module graph (which requires BOX_ENV) - Update check-install to use ESM import for infra_version.js - Convert scripts/ (hotfix, release, remote_hotfix.js, find-unused-translations) - All 1315 tests passing Migration stats (AI-assisted using Cursor with Claude): - Wall clock time: ~3-4 hours - Assistant completions: ~80-100 - Estimated token usage: ~1-2M tokens Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
+26
-25
@@ -1,6 +1,29 @@
|
||||
'use strict';
|
||||
import apps from './apps.js';
|
||||
import assert from 'node:assert';
|
||||
import * as backupFormats from './backupformats.js';
|
||||
import backups from './backups.js';
|
||||
import * as backupSites from './backupsites.js';
|
||||
import BoxError from './boxerror.js';
|
||||
import constants from './constants.js';
|
||||
import crypto from 'node:crypto';
|
||||
import DataLayout from './datalayout.js';
|
||||
import * as database from './database.js';
|
||||
import debugModule from 'debug';
|
||||
import * as df from './df.js';
|
||||
import locks from './locks.js';
|
||||
import path from 'node:path';
|
||||
import paths from './paths.js';
|
||||
import { Readable } from 'node:stream';
|
||||
import safe from 'safetydance';
|
||||
import services from './services.js';
|
||||
import shellModule from './shell.js';
|
||||
import stream from 'stream/promises';
|
||||
import util from 'util';
|
||||
|
||||
exports = module.exports = {
|
||||
const debug = debugModule('box:backuptask');
|
||||
const shell = shellModule('backuptask');
|
||||
|
||||
export {
|
||||
fullBackup,
|
||||
appBackup,
|
||||
|
||||
@@ -14,29 +37,7 @@ exports = module.exports = {
|
||||
upload,
|
||||
};
|
||||
|
||||
const apps = require('./apps.js'),
|
||||
assert = require('node:assert'),
|
||||
backupFormats = require('./backupformats.js'),
|
||||
backups = require('./backups.js'),
|
||||
backupSites = require('./backupsites.js'),
|
||||
BoxError = require('./boxerror.js'),
|
||||
constants = require('./constants.js'),
|
||||
crypto = require('node:crypto'),
|
||||
DataLayout = require('./datalayout.js'),
|
||||
database = require('./database.js'),
|
||||
debug = require('debug')('box:backuptask'),
|
||||
df = require('./df.js'),
|
||||
locks = require('./locks.js'),
|
||||
path = require('node:path'),
|
||||
paths = require('./paths.js'),
|
||||
{ Readable } = require('node:stream'),
|
||||
safe = require('safetydance'),
|
||||
services = require('./services.js'),
|
||||
shell = require('./shell.js')('backuptask'),
|
||||
stream = require('stream/promises'),
|
||||
util = require('util');
|
||||
|
||||
const BACKUP_UPLOAD_CMD = path.join(__dirname, 'scripts/backupupload.js');
|
||||
const BACKUP_UPLOAD_CMD = path.join(import.meta.dirname, 'scripts/backupupload.js');
|
||||
|
||||
function addFileExtension(backupSite, remotePath) {
|
||||
assert.strictEqual(typeof backupSite, 'object');
|
||||
|
||||
Reference in New Issue
Block a user