From 956f941f7d2907773cddd2f7ff91f8f033feb90c Mon Sep 17 00:00:00 2001 From: Girish Ramakrishnan Date: Sun, 1 Feb 2015 20:26:55 -0800 Subject: [PATCH] Polling through docker network is the right thing to do --- apphealthtask.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apphealthtask.js b/apphealthtask.js index 77067b5ea..313af839e 100755 --- a/apphealthtask.js +++ b/apphealthtask.js @@ -69,7 +69,6 @@ function setHealth(app, alive, runState, callback) { } -// # TODO should probably poll from the outside network instead of the docker network? // callback is called with error for fatal errors and not if health check failed function checkAppHealth(app, callback) { // only check status of installed apps. we could possibly optimize more by checking runState as well @@ -89,6 +88,7 @@ function checkAppHealth(app, callback) { return setHealth(app, false, appdb.RSTATE_DEAD, callback); } + // poll through docker network instead of nginx to bypass any potential oauth proxy var healthCheckUrl = 'http://127.0.0.1:' + app.httpPort + manifest.healthCheckPath; superagent .get(healthCheckUrl)