diff --git a/src/cert/acme2.js b/src/cert/acme2.js index 44879278f..1cf20cb99 100644 --- a/src/cert/acme2.js +++ b/src/cert/acme2.js @@ -134,7 +134,7 @@ Acme2.prototype.updateContact = function (registrationUri, callback) { const that = this; this.sendSignedRequest(registrationUri, JSON.stringify(payload), function (error, result) { - if (error) return callback(new BoxError(BoxError.NETWORK_ERROR, 'Network error when registering user: ' + error.message)); + if (error) return callback(new BoxError(BoxError.NETWORK_ERROR, `Network error when updating contact: ${error.message}`)); if (result.statusCode !== 200) return callback(new BoxError(BoxError.EXTERNAL_ERROR, util.format('Failed to update contact. Expecting 200, got %s %s', result.statusCode, result.text))); debug(`updateContact: contact of user updated to ${that.email}`); @@ -154,7 +154,7 @@ Acme2.prototype.registerUser = function (callback) { var that = this; this.sendSignedRequest(this.directory.newAccount, JSON.stringify(payload), function (error, result) { - if (error) return callback(new BoxError(BoxError.NETWORK_ERROR, 'Network error when registering new account: ' + error.message)); + if (error) return callback(new BoxError(BoxError.NETWORK_ERROR, `Network error when registering user: ${error.message}`)); // 200 if already exists. 201 for new accounts if (result.statusCode !== 200 && result.statusCode !== 201) return callback(new BoxError(BoxError.EXTERNAL_ERROR, util.format('Failed to register new account. Expecting 200 or 201, got %s %s', result.statusCode, result.text))); @@ -180,7 +180,7 @@ Acme2.prototype.newOrder = function (domain, callback) { debug('newOrder: %s', domain); this.sendSignedRequest(this.directory.newOrder, JSON.stringify(payload), function (error, result) { - if (error) return callback(new BoxError(BoxError.NETWORK_ERROR, 'Network error when registering domain: ' + error.message)); + if (error) return callback(new BoxError(BoxError.NETWORK_ERROR, `Network error when creating new order: ${error.message}`)); if (result.statusCode === 403) return callback(new BoxError(BoxError.ACCESS_DENIED, `Forbidden sending signed request: ${result.body.detail}`)); if (result.statusCode !== 201) return callback(new BoxError(BoxError.EXTERNAL_ERROR, util.format('Failed to register user. Expecting 201, got %s %s', result.statusCode, result.text))); @@ -253,7 +253,7 @@ Acme2.prototype.notifyChallengeReady = function (challenge, callback) { }; this.sendSignedRequest(challenge.url, JSON.stringify(payload), function (error, result) { - if (error) return callback(new BoxError(BoxError.NETWORK_ERROR, 'Network error when notifying challenge: ' + error.message)); + if (error) return callback(new BoxError(BoxError.NETWORK_ERROR, `Network error when notifying challenge: ${error.message}`)); if (result.statusCode !== 200) return callback(new BoxError(BoxError.EXTERNAL_ERROR, util.format('Failed to notify challenge. Expecting 200, got %s %s', result.statusCode, result.text))); callback(); @@ -272,7 +272,7 @@ Acme2.prototype.waitForChallenge = function (challenge, callback) { superagent.get(challenge.url).timeout(30 * 1000).end(function (error, result) { if (error && !error.response) { debug('waitForChallenge: network error getting uri %s', challenge.url); - return retryCallback(new BoxError(BoxError.NETWORK_ERROR, error.message)); // network error + return retryCallback(new BoxError(BoxError.NETWORK_ERROR, `Network error waiting for challenge: ${error.message}`)); } if (result.statusCode !== 200) { debug('waitForChallenge: invalid response code getting uri %s', result.statusCode); @@ -305,7 +305,7 @@ Acme2.prototype.signCertificate = function (domain, finalizationUrl, csrDer, cal debug('signCertificate: sending sign request'); this.sendSignedRequest(finalizationUrl, JSON.stringify(payload), function (error, result) { - if (error) return callback(new BoxError(BoxError.NETWORK_ERROR, 'Network error when signing certificate: ' + error.message)); + if (error) return callback(new BoxError(BoxError.NETWORK_ERROR, `Network error when signing certificate: ${error.message}`)); // 429 means we reached the cert limit for this domain if (result.statusCode !== 200) return callback(new BoxError(BoxError.EXTERNAL_ERROR, util.format('Failed to sign certificate. Expecting 200, got %s %s', result.statusCode, result.text))); @@ -354,7 +354,7 @@ Acme2.prototype.downloadCertificate = function (hostname, certUrl, callback) { res.on('data', function(chunk) { data.push(chunk); }); res.on('end', function () { res.text = Buffer.concat(data); done(); }); }).timeout(30 * 1000).end(function (error, result) { - if (error && !error.response) return callback(new BoxError(BoxError.NETWORK_ERROR, 'Network error when downloading certificate')); + if (error && !error.response) return callback(new BoxError(BoxError.NETWORK_ERROR, `Network error when downloading certificate: ${error.message}`)); if (result.statusCode === 202) return callback(new BoxError(BoxError.TRY_AGAIN, 'Retry not implemented yet')); if (result.statusCode !== 200) return callback(new BoxError(BoxError.EXTERNAL_ERROR, util.format('Failed to get cert. Expecting 200, got %s %s', result.statusCode, result.text))); @@ -485,7 +485,7 @@ Acme2.prototype.prepareChallenge = function (hostname, domain, authorizationUrl, const that = this; superagent.get(authorizationUrl).timeout(30 * 1000).end(function (error, response) { - if (error && !error.response) return callback(new BoxError(BoxError.NETWORK_ERROR, 'Network error when preparing challenge')); + if (error && !error.response) return callback(new BoxError(BoxError.NETWORK_ERROR, `Network error when preparing challenge: ${error.message}`)); if (response.statusCode !== 200) return callback(new BoxError(BoxError.EXTERNAL_ERROR, 'Invalid response code getting authorization : ' + response.statusCode)); const authorization = response.body; @@ -566,7 +566,7 @@ Acme2.prototype.getDirectory = function (callback) { const that = this; superagent.get(this.caDirectory).timeout(30 * 1000).end(function (error, response) { - if (error && !error.response) return callback(new BoxError(BoxError.NETWORK_ERROR, 'Network error getting directory')); + if (error && !error.response) return callback(new BoxError(BoxError.NETWORK_ERROR, `Network error getting directory: ${error.message}`)); if (response.statusCode !== 200) return callback(new BoxError(BoxError.EXTERNAL_ERROR, 'Invalid response code when fetching directory : ' + response.statusCode)); if (typeof response.body.newNonce !== 'string' ||