diff --git a/src/routes/setup.js b/src/routes/setup.js index 7a346ff00..883950ac4 100644 --- a/src/routes/setup.js +++ b/src/routes/setup.js @@ -78,6 +78,7 @@ function dnsSetup(req, res, next) { setup.dnsSetup(req.body.adminFqdn.toLowerCase(), req.body.domain.toLowerCase(), req.body.zoneName || '', req.body.provider, req.body.config, req.body.tlsConfig || { provider: 'letsencrypt-prod' }, function (error) { if (error && error.reason === SetupError.ALREADY_SETUP) return next(new HttpError(409, error.message)); if (error && error.reason === SetupError.BAD_FIELD) return next(new HttpError(400, error.message)); + if (error && error.reason === SetupError.BAD_STATE) return next(new HttpError(409, error.message)); if (error) return next(new HttpError(500, error)); next(new HttpSuccess(200)); diff --git a/src/setup.js b/src/setup.js index a888d1ebb..2dd8ee973 100644 --- a/src/setup.js +++ b/src/setup.js @@ -32,7 +32,6 @@ var assert = require('assert'), semver = require('semver'), settingsdb = require('./settingsdb.js'), settings = require('./settings.js'), - SettingsError = settings.SettingsError, shell = require('./shell.js'), superagent = require('superagent'), sysinfo = require('./sysinfo.js'), @@ -192,9 +191,9 @@ function dnsSetup(adminFqdn, domain, zoneName, provider, dnsConfig, tlsConfig, c } domains.get(domain, function (error, result) { - if (error && error.reason !== DomainsError.NOT_FOUND) return callback(new SettingsError(SettingsError.INTERNAL_ERROR, error)); + if (error && error.reason !== DomainsError.NOT_FOUND) return callback(new SetupError(SetupError.INTERNAL_ERROR, error)); - if (result) return callback(new SettingsError(SettingsError.ALREADY_EXISTS, 'domain already exists')); + if (result) return callback(new SetupError(SetupError.BAD_STATE, 'Domain already exists')); async.series([ domains.add.bind(null, domain, zoneName, provider, dnsConfig, null /* cert */, tlsConfig),