From 87d25336e7131dc44f063e10d37a2d83f283b056 Mon Sep 17 00:00:00 2001
From: Johannes Zellner <johannes@cloudron.io>
Date: Wed, 21 May 2025 10:49:05 +0200
Subject: [PATCH] Fixup the LDAP provider view

---
 .../views/UserDirectoryLdapProviderView.vue    | 18 ++++++++----------
 1 file changed, 8 insertions(+), 10 deletions(-)

diff --git a/dashboard/src/views/UserDirectoryLdapProviderView.vue b/dashboard/src/views/UserDirectoryLdapProviderView.vue
index f88285a2c..867b13ea8 100644
--- a/dashboard/src/views/UserDirectoryLdapProviderView.vue
+++ b/dashboard/src/views/UserDirectoryLdapProviderView.vue
@@ -21,9 +21,11 @@ const secret = ref('');
 const allowlist = ref('');
 
 const isValid = computed(() => {
-  if (!enabled.value) return true;
-  if (!secret.value) return false;
-  if (!allowlist.value) return false;
+  if (enabled.value) {
+    if (!secret.value) return false;
+    if (!allowlist.value) return false;
+  }
+
   return true;
 });
 
@@ -82,7 +84,7 @@ onMounted(async () => {
         <fieldset :disabled="busy">
           <input style="display: none" type="submit" :disabled="busy || !isValid" />
 
-          <Checkbox v-model="enabled" :label="$t('users.exposedLdap.enabled')" /><sup><a href="https://docs.cloudron.io/user-directory/#directory-server" class="help" target="_blank"><i class="fa fa-question-circle"></i></a></sup>
+          <Checkbox v-model="enabled" :label="$t('users.exposedLdap.enabled')" style="display: inline-flex; margin-right: 6px;"/><sup><a href="https://docs.cloudron.io/user-directory/#directory-server" class="help" target="_blank"><i class="fa fa-question-circle"></i></a></sup>
 
           <FormGroup>
             <label for="ldapUrlInput">{{ $t('users.exposedLdap.secret.url') }}</label>
@@ -106,13 +108,9 @@ onMounted(async () => {
         </fieldset>
       </form>
 
-      <br/>
+      <div class="error-label" v-show="editError.generic">{{ editError.generic }}</div>
 
-      <p class="has-error" v-show="editError.generic">{{ editError.generic }}</p>
-
-      <div class="button-bar">
-        <Button :loading="busy" :disabled="!isValid || busy" @click="onSubmit()">{{ $t('users.settings.saveAction') }}</Button>
-      </div>
+      <Button :loading="busy" :disabled="!isValid || busy" @click="onSubmit()">{{ $t('users.settings.saveAction') }}</Button>
     </Section>
   </div>
 </template>