From 7e543a64e4b3675fed02428fe27e38aaf0b951ec Mon Sep 17 00:00:00 2001
From: Johannes Zellner <johannes@cloudron.io>
Date: Wed, 6 Aug 2025 13:53:21 +0200
Subject: [PATCH] Only rsync format supports hardlinks, chown and preserving of
 fs attributes

---
 .../src/components/BackupProviderForm.vue      | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/dashboard/src/components/BackupProviderForm.vue b/dashboard/src/components/BackupProviderForm.vue
index e7c1f3b90..c908d24b8 100644
--- a/dashboard/src/components/BackupProviderForm.vue
+++ b/dashboard/src/components/BackupProviderForm.vue
@@ -194,15 +194,6 @@ onMounted(async () => {
       <TextInput id="backupDirInput" v-model="providerConfig.backupDir" placeholder="Directory for backups" required />
     </FormGroup>
 
-    <!-- Filesystem/SSHFS/CIFS/NFS/EXT4/mountpoint -->
-    <Checkbox v-if="(provider === 'filesystem' || mountlike(provider)) && !importOnly && format === 'rsync'" v-model="providerConfig.useHardlinks" :label="$t('backups.configureBackupStorage.hardlinksLabel')"/>
-
-    <!-- CIFS/mountpoint -->
-    <Checkbox v-if="(provider === 'mountpoint' || provider === 'cifs') && !importOnly" v-model="providerConfig.preserveAttributes" :label="$t('backups.configureBackupStorage.preserveAttributesLabel')"/>
-
-    <!-- mountpoint -->
-    <Checkbox v-if="provider === 'mountpoint' && !importOnly" v-model="providerConfig.chown" :label="$t('backups.configureBackupStorage.chown')"/>
-
     <!-- S3/Minio/SOS/GCS/UpCloud/B2/R2 -->
     <FormGroup v-if="provider === 'minio' || provider === 'upcloud-objectstorage' || provider === 'backblaze-b2' || provider === 'cloudflare-r2' || provider === 's3-v4-compat' || provider === 'idrive-e2'">
       <label for="endpointInput">{{ $t('backups.configureBackupStorage.s3Endpoint') }}</label>
@@ -280,5 +271,14 @@ onMounted(async () => {
       <SingleSelect id="formatInput" v-model="format" :options="BACKUP_FORMATS" option-label="name" option-key="value" required />
       <div class="warning-label" v-show="format === 'rsync' && (s3like(provider) || provider === 'gcs') && !importOnly">{{ $t('backups.configureBackupStorage.s3LikeNote') }} <sup><a href="https://docs.cloudron.io/backups/#amazon-s3" class="help" target="_blank"><i class="fa fa-question-circle"></i></a></sup></div>
     </FormGroup>
+
+    <!-- Filesystem/SSHFS/CIFS/NFS/EXT4/mountpoint -->
+    <Checkbox v-if="(provider === 'filesystem' || mountlike(provider)) && !importOnly && format === 'rsync'" v-model="providerConfig.useHardlinks" :label="$t('backups.configureBackupStorage.hardlinksLabel')"/>
+
+    <!-- CIFS/mountpoint -->
+    <Checkbox v-if="(provider === 'mountpoint' || provider === 'cifs') && !importOnly && format === 'rsync'" v-model="providerConfig.preserveAttributes" :label="$t('backups.configureBackupStorage.preserveAttributesLabel')"/>
+
+    <!-- mountpoint -->
+    <Checkbox v-if="provider === 'mountpoint' && !importOnly && format === 'rsync'" v-model="providerConfig.chown" :label="$t('backups.configureBackupStorage.chown')"/>
   </div>
 </template>