eventlog: async'ify

This commit is contained in:
Girish Ramakrishnan
2021-06-01 09:35:20 -07:00
parent bdbda9b80e
commit 7aac4455a9
11 changed files with 309 additions and 657 deletions
+31 -3
View File
@@ -5,16 +5,26 @@ const async = require('async'),
database = require('../../database.js'),
expect = require('expect.js'),
server = require('../../server.js'),
superagent = require('superagent');
superagent = require('superagent'),
tokendb = require('../../tokendb.js');
exports = module.exports = {
setup,
cleanup,
owner: {
id: null,
username: 'superadmin',
password: 'Foobar?1337',
email: 'silly@me.com',
email: 'superadmin@cloudron.local',
token: null
},
user: {
id: null,
username: 'user',
password: 'Foobar?1338',
email: 'user@cloudron.local',
token: null
},
@@ -22,7 +32,7 @@ exports = module.exports = {
};
function setup(done) {
const owner = exports.owner, serverUrl = exports.serverUrl;
const owner = exports.owner, serverUrl = exports.serverUrl, user = exports.user;
async.series([
server.start.bind(null),
@@ -38,10 +48,28 @@ function setup(done) {
// stash token for further use
owner.token = result.body.token;
owner.id = result.body.id;
callback();
});
},
function createUser(callback) {
superagent.post(`${serverUrl}/api/v1/users`)
.query({ access_token: owner.token })
.send({ username: user.username, email: user.email })
.end(function (error, result) {
expect(error).to.not.be.ok();
expect(result.statusCode).to.equal(201);
user.id = result.body.id;
user.token = 'usertoken';
// HACK to get a token for second user (passwords are generated and the user should have gotten a password setup link...)
tokendb.add({ id: 'tid-3', accessToken: user.token, identifier: user.id, clientId: 'test-client-id', expires: Date.now() + 10000, scope: 'unused', name: 'fromtest' }, callback);
});
}
], done);
}
+76 -172
View File
@@ -6,214 +6,118 @@
'use strict';
var async = require('async'),
constants = require('../../constants.js'),
database = require('../../database.js'),
eventlogdb = require('../../eventlogdb.js'),
const async = require('async'),
common = require('./common.js'),
eventlog = require('../../eventlog.js'),
expect = require('expect.js'),
hat = require('../../hat.js'),
superagent = require('superagent'),
server = require('../../server.js'),
tokendb = require('../../tokendb.js');
var SERVER_URL = 'http://localhost:' + constants.PORT;
var USERNAME = 'superadmin', PASSWORD = 'Foobar?1337', EMAIL ='silly@me.com';
var token = null;
var USER_1_ID = null, token_1;
var EVENT_0 = {
id: 'event_0',
action: 'foobaraction',
source: {
ip: '127.0.0.1'
},
data: {
something: 'is there'
}
};
function setup(done) {
async.series([
server.start.bind(server),
database._clear,
function createAdmin(callback) {
superagent.post(SERVER_URL + '/api/v1/cloudron/activate')
.query({ setupToken: 'somesetuptoken' })
.send({ username: USERNAME, password: PASSWORD, email: EMAIL })
.end(function (error, result) {
expect(result).to.be.ok();
expect(result.statusCode).to.eql(201);
// stash token for further use
token = result.body.token;
callback();
});
},
function (callback) {
superagent.post(SERVER_URL + '/api/v1/users')
.query({ access_token: token })
.send({ username: 'nonadmin', email: 'notadmin@server.test' })
.end(function (err, res) {
expect(res.statusCode).to.equal(201);
USER_1_ID = res.body.id;
callback(null);
});
},
function (callback) {
token_1 = hat(8 * 32);
// HACK to get a token for second user (passwords are generated and the user should have gotten a password setup link...)
tokendb.add({ id: 'tid-0', accessToken: token_1, identifier: USER_1_ID, clientId: 'test-client-id', expires: Date.now() + 100000, scope: 'unused', name: '' }, callback);
},
function (callback) {
eventlogdb.add(EVENT_0.id, EVENT_0.action, EVENT_0.source, EVENT_0.data, callback);
}
], done);
}
function cleanup(done) {
database._clear(function (error) {
expect(!error).to.be.ok();
server.stop(done);
});
}
superagent = require('superagent');
describe('Eventlog API', function () {
before(setup);
const { setup, cleanup, serverUrl, owner, user } = common;
const EVENT_0 = {
id: null,
action: 'foobaraction',
source: {ip: '127.0.0.1' },
data: { something: 'is there' }
};
before(function (done) {
async.series([
setup,
async () => { EVENT_0.id = await eventlog.add(EVENT_0.action, EVENT_0.source, EVENT_0.data); },
], done);
});
after(cleanup);
describe('get', function () {
it('fails due to wrong token', function (done) {
superagent.get(SERVER_URL + '/api/v1/cloudron/eventlog/' + EVENT_0.id)
.query({ access_token: token.toUpperCase() })
.end(function (error, result) {
expect(result.statusCode).to.equal(401);
done();
});
it('fails due to wrong token', async function () {
const response = await superagent.get(`${serverUrl}/api/v1/cloudron/eventlog/someid`)
.query({ access_token: 'badtoken' })
.ok(() => true);
expect(response.statusCode).to.be(401);
});
it('fails for non-admin', function (done) {
superagent.get(SERVER_URL + '/api/v1/cloudron/eventlog/' + EVENT_0.id)
.query({ access_token: token_1 })
.end(function (error, result) {
expect(result.statusCode).to.equal(403);
done();
});
it('fails for non-admin', async function () {
const response = await superagent.get(`${serverUrl}/api/v1/cloudron/eventlog/someid`)
.query({ access_token: user.token })
.ok(() => true);
expect(response.statusCode).to.equal(403);
});
it('fails if not exists', function (done) {
superagent.get(SERVER_URL + '/api/v1/cloudron/eventlog/doesnotexist')
.query({ access_token: token })
.end(function (error, result) {
expect(result.statusCode).to.equal(404);
it('fails if not exists', async function () {
const response = await superagent.get(`${serverUrl}/api/v1/cloudron/eventlog/someid`)
.query({ access_token: owner.token })
.ok(() => true);
done();
});
expect(response.statusCode).to.equal(404);
});
it('succeeds for admin', function (done) {
superagent.get(SERVER_URL + '/api/v1/cloudron/eventlog/' + EVENT_0.id)
.query({ access_token: token })
.end(function (error, result) {
expect(result.statusCode).to.equal(200);
expect(result.body.event).to.be.an('object');
expect(result.body.event.creationTime).to.be.a('string');
it('succeeds for admin', async function () {
const response = await superagent.get(`${serverUrl}/api/v1/cloudron/eventlog/${EVENT_0.id}`)
.query({ access_token: owner.token })
.ok(() => true);
delete result.body.event.creationTime;
expect(result.body.event).to.eql(EVENT_0);
done();
});
expect(response.statusCode).to.equal(200);
delete response.body.event.creationTime;
expect(response.body.event).to.eql(EVENT_0);
});
});
describe('list', function () {
it('fails due to wrong token', function (done) {
superagent.get(SERVER_URL + '/api/v1/cloudron/eventlog')
.query({ access_token: token.toUpperCase() })
.end(function (error, result) {
expect(result.statusCode).to.equal(401);
done();
});
it('fails due to wrong token', async function () {
const response = await superagent.get(`${serverUrl}/api/v1/cloudron/eventlog`)
.query({ access_token: 'badtoken' })
.ok(() => true);
expect(response.statusCode).to.equal(401);
});
it('fails for non-admin', function (done) {
superagent.get(SERVER_URL + '/api/v1/cloudron/eventlog')
.query({ access_token: token_1, page: 1, per_page: 10 })
.end(function (error, result) {
expect(result.statusCode).to.equal(403);
it('fails for non-admin', async function () {
const response = await superagent.get(`${serverUrl}/api/v1/cloudron/eventlog`)
.query({ access_token: user.token, page: 1, per_page: 10 })
.ok(() => true);
done();
});
expect(response.statusCode).to.equal(403);
});
it('succeeds for admin', function (done) {
superagent.get(SERVER_URL + '/api/v1/cloudron/eventlog')
.query({ access_token: token, page: 1, per_page: 10 })
.end(function (error, result) {
expect(result.statusCode).to.equal(200);
expect(result.body.eventlogs.length >= 2).to.be.ok(); // activate, user.add
it('succeeds for admin', async function () {
const response = await superagent.get(`${serverUrl}/api/v1/cloudron/eventlog`)
.query({ access_token: owner.token, page: 1, per_page: 10 });
done();
});
expect(response.statusCode).to.equal(200);
expect(response.body.eventlogs.length >= 2).to.be.ok(); // activate, user.add
});
it('succeeds with deprecated action', function (done) {
superagent.get(SERVER_URL + '/api/v1/cloudron/eventlog')
.query({ access_token: token, page: 1, per_page: 10, action: 'cloudron.activate' })
.end(function (error, result) {
expect(result.statusCode).to.equal(200);
expect(result.body.eventlogs.length).to.equal(1);
it('succeeds with action', async function () {
const response = await superagent.get(`${serverUrl}/api/v1/cloudron/eventlog`)
.query({ access_token: owner.token, page: 1, per_page: 10, action: 'cloudron.activate' });
done();
});
expect(response.statusCode).to.equal(200);
expect(response.body.eventlogs.length).to.equal(1);
});
it('succeeds with actions', function (done) {
superagent.get(SERVER_URL + '/api/v1/cloudron/eventlog')
.query({ access_token: token, page: 1, per_page: 10, actions: 'cloudron.activate, user.add' })
.end(function (error, result) {
expect(result.statusCode).to.equal(200);
expect(result.body.eventlogs.length).to.equal(3);
it('succeeds with actions', async function () {
const response = await superagent.get(`${serverUrl}/api/v1/cloudron/eventlog`)
.query({ access_token: owner.token, page: 1, per_page: 10, actions: 'cloudron.activate, user.add' });
done();
});
expect(response.statusCode).to.equal(200);
expect(response.body.eventlogs.length).to.equal(3);
});
it('succeeds with search', function (done) {
superagent.get(SERVER_URL + '/api/v1/cloudron/eventlog')
.query({ access_token: token, page: 1, per_page: 10, search: EMAIL })
.end(function (error, result) {
expect(result.statusCode).to.equal(200);
expect(result.body.eventlogs.length).to.equal(1);
it('succeeds with search', async function () {
const response = await superagent.get(`${serverUrl}/api/v1/cloudron/eventlog`)
.query({ access_token: owner.token, page: 1, per_page: 10, search: owner.email });
done();
});
expect(response.statusCode).to.equal(200);
expect(response.body.eventlogs.length).to.equal(1);
});
it('succeeds with search', function (done) {
superagent.get(SERVER_URL + '/api/v1/cloudron/eventlog')
.query({ access_token: token, page: 1, per_page: 10, search: EMAIL, actions: 'cloudron.activate' })
.end(function (error, result) {
expect(result.statusCode).to.equal(200);
expect(result.body.eventlogs.length).to.equal(0);
it('succeeds with search and actions', async function () {
const response = await superagent.get(`${serverUrl}/api/v1/cloudron/eventlog`)
.query({ access_token: owner.token, page: 1, per_page: 10, search: owner.email, actions: 'cloudron.activate' });
done();
});
expect(response.statusCode).to.equal(200);
expect(response.body.eventlogs.length).to.equal(0);
});
});
});