Make admin simply a boolean instead of group

This simplifies a lot of logic. Keeping an admin group has no benefit
This commit is contained in:
Girish Ramakrishnan
2018-07-26 17:17:52 -07:00
parent 39848a25a8
commit 78a2176d1d
18 changed files with 280 additions and 359 deletions
-20
View File
@@ -7,9 +7,7 @@
'use strict';
var async = require('async'),
accesscontrol = require('../accesscontrol.js'),
config = require('../config.js'),
constants = require('../constants.js'),
database = require('../database.js'),
DatabaseError = require('../databaseerror.js'),
expect = require('expect.js'),
@@ -362,21 +360,3 @@ describe('Set user groups', function () {
});
});
});
describe('Admin group', function () {
before(function (done) {
async.series([
setup,
userdb.add.bind(null, USER_0.id, USER_0)
], done);
});
after(cleanup);
it('cannot delete admin group ever', function (done) {
groups.remove(constants.ADMIN_GROUP_ID, function (error) {
expect(error.reason).to.equal(GroupsError.NOT_ALLOWED);
done();
});
});
});