diff --git a/CHANGES b/CHANGES index e957a0886..d4b3bb2f3 100644 --- a/CHANGES +++ b/CHANGES @@ -1921,4 +1921,5 @@ * mail: aliases can be across domains * mail: allow an external MX to be set * Add UI to download backup config as JSON (and import it) +* Ensure stopped apps are getting backed up diff --git a/src/backups.js b/src/backups.js index 10aefc4bc..7c1420bf1 100644 --- a/src/backups.js +++ b/src/backups.js @@ -855,9 +855,10 @@ function backupBoxWithAppBackupIds(appBackupIds, tag, progressCallback, callback } function canBackupApp(app) { - // only backup apps that are installed or pending configure or called from apptask. Rest of them are in some - // state not good for consistent backup (i.e addons may not have been setup completely) - return (app.installationState === apps.ISTATE_INSTALLED && app.health === apps.HEALTH_HEALTHY) || + // only backup apps that are installed or specific pending states + // we used to check the health here but that doesn't work for stopped apps. it's better to just fail + // and inform the user if the backup fails and the app addons have not been setup yet. + return app.installationState === apps.ISTATE_INSTALLED || app.installationState === apps.ISTATE_PENDING_CONFIGURE || app.installationState === apps.ISTATE_PENDING_BACKUP || // called from apptask app.installationState === apps.ISTATE_PENDING_UPDATE; // called from apptask