From 723c670100cbe66043df077f06161a99fdef62df Mon Sep 17 00:00:00 2001
From: Girish Ramakrishnan <girish@cloudron.io>
Date: Fri, 20 Feb 2026 19:46:28 +0100
Subject: [PATCH] reverseproxy: fix crash

---
 CHANGES             |  1 +
 src/reverseproxy.js | 12 +++++++-----
 2 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/CHANGES b/CHANGES
index 20861a0fc..2d96e901f 100644
--- a/CHANGES
+++ b/CHANGES
@@ -3142,4 +3142,5 @@
 * filemanager: add a tree view
 * passkey support
 * security: remove cors
+* support card/cal dav well-known endpoints
 
diff --git a/src/reverseproxy.js b/src/reverseproxy.js
index e3c29068a..d510f5d96 100644
--- a/src/reverseproxy.js
+++ b/src/reverseproxy.js
@@ -349,12 +349,14 @@ async function ensureCertificate(location, options, auditSource) {
     debug(`ensureCertificate: ${fqdn} needs acme cert`);
     const [error, result] = await safe(acme2.getCertificate(fqdn, domainObject, key));
 
-    await blobs.setString(`${blobs.CERT_PREFIX}-${certName}.key`, key);
-    await blobs.setString(`${blobs.CERT_PREFIX}-${certName}.cert`, result.cert);
-    await blobs.setString(`${blobs.CERT_PREFIX}-${certName}.csr`, result.csr);
-    await blobs.setString(`${blobs.CERT_PREFIX}-${certName}.renewal`, JSON.stringify(result.renewalInfo));
+    if (!error) {
+        await blobs.setString(`${blobs.CERT_PREFIX}-${certName}.key`, key);
+        await blobs.setString(`${blobs.CERT_PREFIX}-${certName}.cert`, result.cert);
+        await blobs.setString(`${blobs.CERT_PREFIX}-${certName}.csr`, result.csr);
+        await blobs.setString(`${blobs.CERT_PREFIX}-${certName}.renewal`, JSON.stringify(result.renewalInfo));
+    }
 
-    debug(`ensureCertificate: error: ${error ? error.message : 'null'}`);
+    debug(`ensureCertificate: error: ${error?.message || 'null'}`);
 
     await safe(eventlog.add(eventlog.ACTION_CERTIFICATE_NEW, auditSource, { domain: fqdn, errorMessage: error?.message || '', renewalInfo: result.renewalInfo }));
 }