jjkiers/cloudron-box
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Add mail test

Browse Source
This commit is contained in:
Girish Ramakrishnan
2018-01-21 00:06:08 -08:00
parent 04868f0983
commit 70fecb8a75
3 changed files with 54 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/mail.js
View File

@@ -1,9 +1,7 @@
'use strict';
exports = module.exports = {
verifyRelay: verifyRelay,
getStatus: getStatus,
checkRblStatus: checkRblStatus,
get: get,
@@ -135,6 +133,8 @@ function verifyRelay(relay, callback) {
assert.strictEqual(typeof relay, 'object');
assert.strictEqual(typeof callback, 'function');
if (process.env.BOX_ENV === 'test') return callback();
var verifier = relay.provider === 'cloudron-smtp' ? checkOutboundPort25 : checkSmtpRelay.bind(null, relay);
verifier(function (error) {
@@ -463,6 +463,8 @@ function restartMail(callback) {
// MAIL_DOMAIN is the domain for which this server is relaying mails
// mail container uses /app/data for backed up data and /run for restart-able data
if (process.env.BOX_ENV === 'test') return callback();
function onCertificateChanged(domain) {
if (domain === '*.' + config.fqdn() || domain === config.adminFqdn()) restartMail(NOOP_CALLBACK);
}
@@ -542,7 +544,7 @@ function setMailFromValidation(domain, enabled, callback) {
assert.strictEqual(typeof enabled, 'boolean');
assert.strictEqual(typeof callback, 'function');
maildb.update(domain, { enabled: enabled }, function (error) {
maildb.update(domain, { mailFromValidation: enabled }, function (error) {
if (error && error.reason === DatabaseError.NOT_FOUND) return callback(new MailError(MailError.NOT_FOUND));
if (error) return callback(new MailError(MailError.INTERNAL_ERROR, error));

2
src/test/apps-test.js
View File

@@ -221,7 +221,7 @@ describe('Apps', function () {
describe('getters', function () {
it('cannot get invalid app', function (done) {
apps.get('nope', function (error, app) {
apps.get('nope', function (error) {
expect(error).to.be.ok();
expect(error.reason).to.be(AppsError.NOT_FOUND);
done();

95
src/test/mail-test.js
View File

@@ -10,7 +10,14 @@ var async = require('async'),
database = require('../database.js'),
expect = require('expect.js'),
mail = require('../mail.js'),
settingsdb = require('../settingsdb.js');
maildb = require('../maildb.js');
const DOMAIN_0 = {
domain: 'example.com',
zoneName: 'example.com',
provider: 'manual',
config: { }
};
function setup(done) {
config._reset();
@@ -19,6 +26,9 @@ function setup(done) {
async.series([
database.initialize,
database._clear,
// DOMAIN_0 already added for test through domaindb.addDefaultDomain(),
maildb.add.bind(null, DOMAIN_0.domain)
], done);
}
@@ -29,79 +39,70 @@ function cleanup(done) {
], done);
}
describe('Settings', function () {
describe('Mail', function () {
before(setup);
after(cleanup);
describe('values', function () {
before(setup);
after(cleanup);
it('can get default', function (done) {
mail.get(DOMAIN_0.domain, function (error, mailConfig) {
expect(error).to.be(null);
expect(mailConfig.enabled).to.be(false);
expect(mailConfig.mailFromValidation).to.be(true);
expect(mailConfig.catchAll).to.eql([]);
expect(mailConfig.relay).to.eql({ provider: 'cloudron-smtp' });
done();
});
});
it('can set mail from validation', function (done) {
mail.setMailFromValidation(true, function (error) {
expect(error).to.be(null);
done();
});
});
it('can get mail from validation', function (done) {
mail.getMailFromValidation(function (error, enabled) {
expect(error).to.be(null);
expect(enabled).to.be(true);
done();
});
});
it('can get catch all address', function (done) {
mail.getCatchAllAddress(function (error, address) {
expect(error).to.be(null);
expect(address).to.eql([ ]);
done();
});
});
it('can set catch all address', function (done) {
mail.setCatchAllAddress([ 'user1', 'user2' ], function (error) {
mail.setMailFromValidation(DOMAIN_0.domain, false, function (error) {
expect(error).to.be(null);
mail.getCatchAllAddress(function (error, address) {
mail.get(DOMAIN_0.domain, function (error, mailConfig) {
expect(error).to.be(null);
expect(address).to.eql([ 'user1', 'user2' ]);
expect(mailConfig.mailFromValidation).to.be(false);
done();
});
});
});
it('can get mail relay', function (done) {
mail.getMailRelay(function (error, address) {
it('can set catch all address', function (done) {
mail.setCatchAllAddress(DOMAIN_0.domain, [ 'user1', 'user2' ], function (error) {
expect(error).to.be(null);
expect(address).to.eql({ provider: 'cloudron-smtp' });
done();
mail.get(DOMAIN_0.domain, function (error, mailConfig) {
expect(error).to.be(null);
expect(mailConfig.catchAll).to.eql([ 'user1', 'user2' ]);
done();
});
});
});
it('can set mail relay', function (done) {
var relay = { provider: 'external-smtp', host: 'mx.foo.com', port: 25 };
settingsdb.set(mail.MAIL_RELAY_KEY, JSON.stringify(relay), function (error) { // skip the mail server verify()
mail.setMailRelay(DOMAIN_0.domain, relay, function (error) { // skip the mail server verify()
expect(error).to.be(null);
mail.getMailRelay(function (error, address) {
mail.get(DOMAIN_0.domain, function (error, mailConfig) {
expect(error).to.be(null);
expect(address).to.eql(relay);
expect(mailConfig.relay).to.eql(relay);
done();
});
});
});
it('can set mail config', function (done) {
mail.setMailConfig({ enabled: true }, function (error) {
it('can enable mail', function (done) {
mail.setMailEnabled(DOMAIN_0.domain, true, function (error) {
expect(error).to.be(null);
done();
});
});
it('can get mail config', function (done) {
mail.getMailConfig(function (error, mailConfig) {
expect(error).to.be(null);
expect(mailConfig.enabled).to.be(true);
done();
mail.get(DOMAIN_0.domain, function (error, mailConfig) {
expect(error).to.be(null);
expect(mailConfig.enabled).to.be(true);
done();
});
});
});
});