backups: set label of backup and control it's retention

src/routes/test/backups-test.js

@@ -7,15 +7,27 @@
 
 const common = require('./common.js'),
     expect = require('expect.js'),
+    settings = require('../../settings.js'),
     superagent = require('superagent');
 
 describe('Backups API', function () {
-    const { setup, cleanup, serverUrl, owner } = common;
+    const { setup, cleanup, waitForTask, serverUrl, owner } = common;
 
     before(setup);
     after(cleanup);
 
     describe('create', function () {
+        before(async function () {
+            await settings.setBackupConfig({
+                provider: 'filesystem',
+                backupFolder: '/tmp/backups',
+                format: 'tgz',
+                encryption: null,
+                retentionPolicy: { keepWithinSecs: 2 * 24 * 60 * 60 }, // 2 days
+                schedulePattern: '00 00 23 * * *' // every day at 11pm
+            });
+        });
+
         it('fails due to mising token', async function () {
             const response = await superagent.post(`${serverUrl}/api/v1/backups/create`)
                 .ok(() => true);
@@ -34,6 +46,7 @@ describe('Backups API', function () {
                 .query({ access_token: owner.token });
             expect(response.statusCode).to.equal(202);
             expect(response.body.taskId).to.be.a('string');
+            await waitForTask(response.body.taskId);
         });
     });
 
@@ -42,7 +55,43 @@ describe('Backups API', function () {
             const response = await superagent.get(`${serverUrl}/api/v1/backups`)
                 .query({ access_token: owner.token });
             expect(response.statusCode).to.equal(200);
-            expect(response.body.backups).to.be.an('array');
+            expect(response.body.backups.length).to.be(1);
+        });
+    });
+
+    describe('update', function () {
+        let someBackup;
+
+        before(async function () {
+            const response = await superagent.get(`${serverUrl}/api/v1/backups`)
+                .query({ access_token: owner.token });
+            expect(response.statusCode).to.equal(200);
+            someBackup = response.body.backups[0];
+            console.log(someBackup);
+        });
+
+        it('fails for bad param', async function () {
+            const response = await superagent.post(`${serverUrl}/api/v1/backups/bad_id`)
+                .query({ access_token: owner.token })
+                .send({ preserveSecs: 'not-a-number' })
+                .ok(() => true);
+            expect(response.statusCode).to.equal(400);
+        });
+
+        it('fails for unknown backup', async function () {
+            const response = await superagent.post(`${serverUrl}/api/v1/backups/bad_id`)
+                .query({ access_token: owner.token })
+                .send({ preserveSecs: 30, label: 'NewOrleans' })
+                .ok(() => true);
+
+            expect(response.statusCode).to.equal(404);
+        });
+
+        it('succeeds', async function () {
+            const response = await superagent.post(`${serverUrl}/api/v1/backups/${someBackup.id}`)
+                .query({ access_token: owner.token })
+                .send({ preserveSecs: 30, label: 'NewOrleans' });
+            expect(response.statusCode).to.equal(400);
         });
     });
 });

src/routes/test/common.js

@@ -11,6 +11,7 @@ const constants = require('../../constants.js'),
     settings = require('../../settings.js'),
     support = require('../../support.js'),
     superagent = require('superagent'),
+    tasks = require('../../tasks.js'),
     tokens = require('../../tokens.js');
 
 exports = module.exports = {
@@ -19,6 +20,7 @@ exports = module.exports = {
     cleanup,
     clearMailQueue,
     checkMails,
+    waitForTask,
 
     owner: {
         id: null,
@@ -99,3 +101,15 @@ async function checkMails(number) {
     expect(mailer._mailQueue.length).to.equal(number);
     clearMailQueue();
 }
+
+async function waitForTask(taskId) {
+    // eslint-disable-next-line no-constant-condition
+    for (let i = 0; i < 10; i++) {
+        const result = await tasks.get(taskId);
+        expect(result).to.not.be(null);
+        if (!result.active) return;
+        await delay(2000);
+        console.log(`Waiting for task to ${taskId} finish`);
+    }
+    throw new Error(`Task ${taskId} never finished`);
+}