From 6dc2e1aa14957d31454b20d685f346a0b2a04e5c Mon Sep 17 00:00:00 2001
From: Girish Ramakrishnan <girish@cloudron.io>
Date: Mon, 13 Jan 2020 14:54:19 -0800
Subject: [PATCH] Do not show error page for 503

WP maintenance mode plugin will return 503
---
 CHANGES             | 2 ++
 src/nginxconfig.ejs | 5 ++++-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/CHANGES b/CHANGES
index c9bcec3f5..cf535c407 100644
--- a/CHANGES
+++ b/CHANGES
@@ -1768,3 +1768,5 @@
 
 [4.4.5]
 * Fix user listing regression in group edit dialog
+* Do not show error page for 503
+
diff --git a/src/nginxconfig.ejs b/src/nginxconfig.ejs
index 7f4f257d2..5c5eddc8d 100644
--- a/src/nginxconfig.ejs
+++ b/src/nginxconfig.ejs
@@ -108,7 +108,9 @@ server {
 <% } -%>
 
     proxy_http_version 1.1;
+    # intercept errors (>= 400) and use the error_page handler
     proxy_intercept_errors on;
+    # nginx will return 504 on connect/timeout errors
     proxy_read_timeout       3500;
     proxy_connect_timeout    3250;
 
@@ -125,7 +127,8 @@ server {
 
     # only serve up the status page if we get proxy gateway errors
     root <%= sourceDir %>/dashboard/dist;
-    error_page 502 503 504 /appstatus.html;
+    # some apps use 503 to indicate updating or maintenance
+    error_page 502 504 /appstatus.html;
     location /appstatus.html {
         internal;
     }