From 6c8c7751fd82de2c9b404ede88e9b2d3778c8200 Mon Sep 17 00:00:00 2001
From: Girish Ramakrishnan <girish@cloudron.io>
Date: Fri, 24 May 2019 10:15:05 -0700
Subject: [PATCH] Add note that access control allows SFTP access

---
 src/views/apps.html | 22 ++++++++++++++--------
 src/views/apps.js   |  3 +++
 2 files changed, 17 insertions(+), 8 deletions(-)

diff --git a/src/views/apps.html b/src/views/apps.html
index 2826af5c5..d3661930a 100644
--- a/src/views/apps.html
+++ b/src/views/apps.html
@@ -53,14 +53,20 @@
                                 </div>
 
                                 <div class="form-group">
-                                    <label ng-show="appConfigure.ssoAuth" class="control-label">User management</label>
-                                    <label ng-show="!appConfigure.ssoAuth" class="control-label">Dashboard visibility</label>
-                                    <p ng-show="!appConfigure.ssoAuth && !appConfigure.app.manifest.addons.email" class="text-small">
-                                        This app has it's own user management.
-                                    </p>
-                                    <p ng-show="!appConfigure.ssoAuth && appConfigure.app.manifest.addons.email">
-                                        This app is pre-configured for use with <a href="https://cloudron.io/documentation/email/" target="_blank">Cloudron Email</a>.
-                                    </p>
+                                    <div ng-show="appConfigure.ssoAuth">
+                                        <label class="control-label">User management</label>
+                                        <p class="text-small" ng-show="appConfigure.ftp">This setting also controls SFTP access.</p>
+                                    </div>
+                                    <div ng-show="!appConfigure.ssoAuth">
+                                      <label class="control-label">Dashboard visibility</label>
+                                      <p ng-show="!appConfigure.app.manifest.addons.email" class="text-small">
+                                          This app has it's own user management.
+                                          <span ng-show="appConfigure.ftp">This setting also controls SFTP access.</span>
+                                      </p>
+                                      <p ng-show="appConfigure.app.manifest.addons.email">
+                                          This app is pre-configured for use with <a href="https://cloudron.io/documentation/email/" target="_blank">Cloudron Email</a>.
+                                      </p>
+                                    </div>
 
                                     <div class="radio">
                                         <label>
diff --git a/src/views/apps.js b/src/views/apps.js
index d5e020558..3162b4e2d 100644
--- a/src/views/apps.js
+++ b/src/views/apps.js
@@ -48,6 +48,7 @@ angular.module('Application').controller('AppsController', ['$scope', '$location
         alternateSubdomain: '',
         alternateDomain: null,
         ssoAuth: false,
+        ftp: false,
         tags: '',
         label: '',
         icon: { file: null, data: null, url: null },
@@ -81,6 +82,7 @@ angular.module('Application').controller('AppsController', ['$scope', '$location
             $scope.appConfigure.label = app.label || '';
 
             $scope.appConfigure.ssoAuth = (app.manifest.addons['ldap'] || app.manifest.addons['oauth']) && app.sso;
+            $scope.appConfigure.ftp = app.manifest.addons.localstorage && app.manifest.addons.localstorage.ftp;
 
             // create ticks starting from manifest memory limit. the memory limit here is currently split into ram+swap (and thus *2 below)
             // TODO: the *2 will overallocate since 4GB is max swap that cloudron itself allocates
@@ -481,6 +483,7 @@ angular.module('Application').controller('AppsController', ['$scope', '$location
         $scope.appConfigure.accessRestrictionOption = 'any';
         $scope.appConfigure.accessRestriction = { users: [], groups: [] };
         $scope.appConfigure.ssoAuth = false;
+        $scope.appConfigure.ftp = false;
         $scope.appConfigure.robotsTxt = '';
         $scope.appConfigure.enableBackup = true;
         $scope.appConfigure.enableAutomaticUpdate = true;