From 6ac914904e4167a46b88872a52b531da0acbdbe5 Mon Sep 17 00:00:00 2001
From: Girish Ramakrishnan <girish@cloudron.io>
Date: Tue, 7 Oct 2025 12:11:16 +0200
Subject: [PATCH] backups: make listing by site only return box backups

---
 src/backups.js                  | 2 +-
 src/routes/test/backups-test.js | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/backups.js b/src/backups.js
index 00641c958..4fab25588 100644
--- a/src/backups.js
+++ b/src/backups.js
@@ -201,7 +201,7 @@ async function listBySiteId(siteId, page, perPage) {
     assert(typeof page === 'number' && page > 0);
     assert(typeof perPage === 'number' && perPage > 0);
 
-    const results = await database.query(`SELECT ${BACKUPS_FIELDS} FROM backups WHERE siteId=? ORDER BY creationTime DESC LIMIT ?,?`, [ siteId, (page-1)*perPage, perPage ]);
+    const results = await database.query(`SELECT ${BACKUPS_FIELDS} FROM backups WHERE siteId=? AND type=? ORDER BY creationTime DESC LIMIT ?,?`, [ siteId, exports.BACKUP_TYPE_BOX, (page-1)*perPage, perPage ]);
 
     results.forEach(function (result) { postProcess(result); });
 
diff --git a/src/routes/test/backups-test.js b/src/routes/test/backups-test.js
index 3aee92165..db5fc7242 100644
--- a/src/routes/test/backups-test.js
+++ b/src/routes/test/backups-test.js
@@ -37,7 +37,7 @@ describe('Backups API', function () {
         const response = await superagent.get(`${serverUrl}/api/v1/backup_sites/${site.id}/backups`)
             .query({ access_token: admin.token });
         expect(response.status).to.equal(200);
-        expect(response.body.backups.length).to.be(2); // this contains the box & mail backup, should it?
+        expect(response.body.backups.length).to.be(1); // only box backups are listed
     });