jjkiers/cloudron-box
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Ensure notifications are sorted by time descending

Browse Source
This commit is contained in:
Johannes Zellner
2019-05-13 22:05:58 +02:00
parent 05dd65718f
commit 63310c44c0
2 changed files with 13 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/test/notifications-test.js
View File

@@ -11,7 +11,6 @@ var async = require('async'),
users = require('../users.js'),
userdb = require('../userdb.js'),
eventlogdb = require('../eventlogdb.js'),
notificationdb = require('../notificationdb.js'),
notifications = require('../notifications.js'),
NotificationsError = notifications.NotificationsError,
expect = require('expect.js');
@@ -152,20 +151,24 @@ describe('Notifications', function () {
});
});
it('getAllPaged succeeds for second page', function (done) {
async.timesSeries(20, function (n, callback) {
notifications._add(USER_0.id, EVENT_0.id, 'title' + n, 'some message', callback);
it('getAllPaged succeeds for second page (takes 5 seconds to add)', function (done) {
async.timesSeries(5, function (n, callback) {
// timeout is for database TIMESTAMP resolution
setTimeout(function () {
notifications._add(USER_0.id, EVENT_0.id, 'title' + n, 'some message', callback);
}, 1000);
}, function (error) {
expect(error).to.eql(null);
notifications.getAllPaged(USER_0.id, null /* ack */, 2, 10, function (error, results) {
notifications.getAllPaged(USER_0.id, null /* ack */, 2, 3, function (error, results) {
expect(error).to.eql(null);
expect(results).to.be.an(Array);
expect(results.length).to.be(10);
expect(results.length).to.be(3);
// we cannot compare the title because ordering is by time which is stored in mysql with seconds
// precision. making the ordering random...
// expect(results[0].title).to.equal('title9');
expect(results[0].title).to.equal('title1');
expect(results[1].title).to.equal('title0');
// the previous tests already add one notification with 'title'
expect(results[2].title).to.equal('title');
done();
});