Check manifest version when installing an app

This should have been done for manifest v1 already. For now, apps will have to put in a minBoxVersion.
2019-06-03 14:02:45 -07:00
parent d3f31a3ace
commit 5ff8ee1a8f
1 changed files with 2 additions and 0 deletions
@@ -1210,6 +1210,8 @@ function stop(appId, callback) {
 function checkManifestConstraints(manifest) {
    assert(manifest && typeof manifest === 'object');

+    if (manifest.manifestVersion > 2) return new AppsError(AppsError.BAD_FIELD, 'Manifest version must be <= 2'); 
+
    if (!manifest.dockerImage) return new AppsError(AppsError.BAD_FIELD, 'Missing dockerImage'); // dockerImage is optional in manifest

    if (semver.valid(manifest.maxBoxVersion) && semver.gt(config.version(), manifest.maxBoxVersion)) {