From 5a9e32d41a1581a81c533a0db7ff4e3a1b09efba Mon Sep 17 00:00:00 2001
From: Girish Ramakrishnan <girish@cloudron.io>
Date: Wed, 1 Jun 2016 06:23:08 -0700
Subject: [PATCH] hide aliases field if no username is set

---
 webadmin/src/views/users.html | 3 +--
 webadmin/src/views/users.js   | 7 ++++++-
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/webadmin/src/views/users.html b/webadmin/src/views/users.html
index ceb90d70a..e77699ef9 100644
--- a/webadmin/src/views/users.html
+++ b/webadmin/src/views/users.html
@@ -98,8 +98,7 @@
                             </span>
                         </div>
                     </div>
-                    <br/>
-                    <div class="form-group" ng-show="(config.isDev || config.isCustomDomain)">
+                    <div class="form-group" ng-show="useredit.userInfo.username && (config.isDev || config.isCustomDomain)">
                         <label class="control-label">Email aliases</label>
                         <div class="form-group">
                             <input type="text" class="form-control" ng-model="useredit.aliases" name="aliases" placeholder="Separate aliases by comma">
diff --git a/webadmin/src/views/users.js b/webadmin/src/views/users.js
index 78d58e9c9..be3f53abf 100644
--- a/webadmin/src/views/users.js
+++ b/webadmin/src/views/users.js
@@ -266,7 +266,12 @@ angular.module('Application').controller('UsersController', ['$scope', '$locatio
                 if (error) return console.error('Unable to update groups for user:', error);
 
                 var aliases = $scope.useredit.aliases ? $scope.useredit.aliases.split(',') : [ ];
-                Client.setAliases($scope.useredit.userInfo.username, aliases, function (error) {
+                var setAliasesFunc = Client.setAliases.bind(null, $scope.useredit.userInfo.username, aliases);
+
+                // cannot set aliases without username
+                if (!$scope.useredit.userInfo.username) setAliasesFunc = function (next) { return next(); };
+
+                setAliasesFunc(function (error) {
                     $scope.useredit.busy = false;
 
                     if (error) return console.error('Unable to update aliases for user:', error);