From 579eacb6446160217dd49368cf4e2f2873c18ae8 Mon Sep 17 00:00:00 2001
From: Girish Ramakrishnan <girish@cloudron.io>
Date: Thu, 19 Sep 2019 16:42:49 -0700
Subject: [PATCH] Better pending state check

---
 src/apptaskmanager.js | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/apptaskmanager.js b/src/apptaskmanager.js
index 02472948a..75ea7fbe4 100644
--- a/src/apptaskmanager.js
+++ b/src/apptaskmanager.js
@@ -90,8 +90,9 @@ function resumeTasks(callback) {
         if (error) return callback(error);
 
         result.forEach(function (app) {
-            if (app.installationState === apps.ISTATE_INSTALLED && (app.runState === apps.RSTATE_RUNNING || app.runState === apps.RSTATE_STOPPED)) return;
-            if (app.installationState === apps.ISTATE_ERROR) return;
+            // if not in any pending state, do nothing
+            if (app.installationState === apps.ISTATE_INSTALLED || app.installationState === apps.ISTATE_ERROR) return;
+            if (app.runState === apps.RSTATE_RUNNING || app.runState === apps.RSTATE_STOPPED) return;
 
             debug(`resumeTask: schedule task for ${app.fqdn} ${app.id}: state=${app.installationState},taskId=${app.taskId}`);