use check_output instead

Aug 14 19:10:46 collectd[12651]: close failed in file object destructor: Aug 14 19:10:46 collectd[12651]: IOError: [Errno 10] No child processes
2017-08-14 12:31:39 -07:00
parent 26361c037d
commit 57891c64b5
1 changed files with 2 additions and 2 deletions
@@ -1,4 +1,4 @@
-import collectd,os
+import collectd,os,subprocess

 # https://blog.dbrgn.ch/2017/3/10/write-a-collectd-python-plugin/

@@ -6,7 +6,7 @@ disks = []

 def init():
    global disks
-    lines = [s.split() for s in os.popen("df --type=ext4 --output=source,target,size,used,avail").read().splitlines()]
+    lines = [s.split() for s in subprocess.check_output(["df", "--type=ext4", "--output=source,target,size,used,avail"]).splitlines()]
    disks = lines[1:] # strip header
    collectd.info('custom df plugin initialized with %s' % disks)