jjkiers/cloudron-box
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Fix oidc tests after removing logoutRedirectUri

Browse Source
This commit is contained in:
Johannes Zellner
2023-07-28 16:47:10 +02:00
parent 1f4c71dcd6
commit 56e1f53890
2 changed files with 5 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
src/routes/test/oidc-test.js
View File

@@ -23,8 +23,7 @@ const CLIENT_1 = {
name: 'test client 1',
secret: 'secret1',
tokenSignatureAlgorithm: 'EdDSA',
loginRedirectUri: 'https://cloudron.io/login',
logoutRedirectUri: 'https://cloudron.io/logout'
loginRedirectUri: 'https://cloudron.io/login'
};
describe('OpenID connect clients API', function () {
@@ -41,7 +40,7 @@ describe('OpenID connect clients API', function () {
expect(response.statusCode).to.equal(401);
});
it('create succeeds without logoutRedirectUri', async function () {
it('create succeeds', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/oidc/clients`)
.query({ access_token: owner.token })
.send(CLIENT_0);
@@ -58,7 +57,7 @@ describe('OpenID connect clients API', function () {
expect(response.statusCode).to.equal(409);
});
it('can create another client with logoutRedirectUri', async function () {
it('can create another client', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/oidc/clients`)
.query({ access_token: owner.token })
.send(CLIENT_1);
@@ -90,7 +89,6 @@ describe('OpenID connect clients API', function () {
expect(response.body.id).to.equal(CLIENT_1.id);
expect(response.body.secret).to.equal(CLIENT_1.secret);
expect(response.body.loginRedirectUri).to.equal(CLIENT_1.loginRedirectUri);
expect(response.body.logoutRedirectUri).to.equal(CLIENT_1.logoutRedirectUri);
expect(response.body.tokenSignatureAlgorithm).to.equal(CLIENT_1.tokenSignatureAlgorithm);
});
@@ -147,40 +145,6 @@ describe('OpenID connect clients API', function () {
expect(response.statusCode).to.equal(400);
});
it('can update client without logoutRedirectUri', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/oidc/clients/${CLIENT_0.id}`)
.query({ access_token: owner.token })
.send({ secret: 'newsecret', name: 'new name', loginRedirectUri: CLIENT_0.loginRedirectUri, tokenSignatureAlgorithm: CLIENT_0.tokenSignatureAlgorithm })
.ok(() => true);
expect(response.statusCode).to.equal(201);
const response2 = await superagent.get(`${serverUrl}/api/v1/oidc/clients/${CLIENT_0.id}`)
.query({ access_token: owner.token });
expect(response2.statusCode).to.equal(200);
expect(response2.body.secret).to.equal('newsecret');
expect(response2.body.name).to.equal('new name');
});
it('can update client with logoutRedirectUri', async function () {
const response = await superagent.post(`${serverUrl}/api/v1/oidc/clients/${CLIENT_0.id}`)
.query({ access_token: owner.token })
.send({ secret: 'newsecret', name: CLIENT_1.name, loginRedirectUri: CLIENT_0.loginRedirectUri, logoutRedirectUri: CLIENT_1.logoutRedirectUri, tokenSignatureAlgorithm: CLIENT_1.tokenSignatureAlgorithm })
.ok(() => true);
expect(response.statusCode).to.equal(201);
const response2 = await superagent.get(`${serverUrl}/api/v1/oidc/clients/${CLIENT_0.id}`)
.query({ access_token: owner.token });
expect(response2.statusCode).to.equal(200);
expect(response2.body.secret).to.equal('newsecret');
expect(response2.body.loginRedirectUri).to.equal(CLIENT_0.loginRedirectUri);
expect(response2.body.logoutRedirectUri).to.equal(CLIENT_1.logoutRedirectUri);
expect(response2.body.tokenSignatureAlgorithm).to.equal(CLIENT_1.tokenSignatureAlgorithm);
});
it('cannot remove without token', async function () {
const response = await superagent.del(`${serverUrl}/api/v1/oidc/clients/${CLIENT_0.id}`)
.ok(() => true);