diff --git a/src/appstore.js b/src/appstore.js index a4ad76304..a81a0fbef 100644 --- a/src/appstore.js +++ b/src/appstore.js @@ -80,11 +80,8 @@ async function login(email, password, totpToken) { assert.strictEqual(typeof password, 'string'); assert.strictEqual(typeof totpToken, 'string'); - const data = { email, password, totpToken }; - - const url = settings.apiServerOrigin() + '/api/v1/login'; - const [error, response] = await safe(superagent.post(url) - .send(data) + const [error, response] = await safe(superagent.post(`${settings.apiServerOrigin()}/api/v1/login`) + .send({ email, password, totpToken }) .timeout(30 * 1000) .ok(() => true)); @@ -99,16 +96,12 @@ async function registerUser(email, password) { assert.strictEqual(typeof email, 'string'); assert.strictEqual(typeof password, 'string'); - const data = { email, password }; - - const url = settings.apiServerOrigin() + '/api/v1/register_user'; - const [error, response] = await safe(superagent.post(url) - .send(data) + const [error, response] = await safe(superagent.post(`${settings.apiServerOrigin()}/api/v1/register_user`) + .send({ email, password }) .timeout(30 * 1000) .ok(() => true)); if (error) throw new BoxError(BoxError.NETWORK_ERROR, error.message); - if (response.status === 409) throw new BoxError(BoxError.ALREADY_EXISTS, 'account already exists'); if (response.status !== 201) throw new BoxError(BoxError.EXTERNAL_ERROR, `register status code: ${response.status}`); } @@ -126,9 +119,7 @@ async function getSubscription() { const token = await settings.getAppstoreApiToken(); if (!token) throw new BoxError(BoxError.LICENSE_ERROR, 'Missing token'); - const url = settings.apiServerOrigin() + '/api/v1/subscription'; - - const [error, response] = await safe(superagent.get(url) + const [error, response] = await safe(superagent.get(`${settings.apiServerOrigin()}/api/v1/subscription`) .query({ accessToken: token }) .timeout(30 * 1000) .ok(() => true)); @@ -159,9 +150,7 @@ async function purchaseApp(data) { const token = await settings.getAppstoreApiToken(); if (!token) throw new BoxError(BoxError.LICENSE_ERROR, 'Missing token'); - const url = `${settings.apiServerOrigin()}/api/v1/cloudronapps`; - - const [error, response] = await safe(superagent.post(url) + const [error, response] = await safe(superagent.post(`${settings.apiServerOrigin()}/api/v1/cloudronapps`) .send(data) .query({ accessToken: token }) .timeout(30 * 1000) @@ -214,15 +203,13 @@ async function getBoxUpdate(options) { const token = await settings.getAppstoreApiToken(); if (!token) throw new BoxError(BoxError.LICENSE_ERROR, 'Missing token'); - const url = `${settings.apiServerOrigin()}/api/v1/boxupdate`; - const query = { accessToken: token, boxVersion: constants.VERSION, automatic: options.automatic }; - const [error, response] = await safe(superagent.get(url) + const [error, response] = await safe(superagent.get(`${settings.apiServerOrigin()}/api/v1/boxupdate`) .query(query) .timeout(30 * 1000) .ok(() => true)); @@ -257,7 +244,6 @@ async function getAppUpdate(app, options) { const token = await settings.getAppstoreApiToken(); if (!token) throw new BoxError(BoxError.LICENSE_ERROR, 'Missing token'); - const url = `${settings.apiServerOrigin()}/api/v1/appupdate`; const query = { accessToken: token, boxVersion: constants.VERSION, @@ -266,7 +252,7 @@ async function getAppUpdate(app, options) { automatic: options.automatic }; - const [error, response] = await safe(superagent.get(url) + const [error, response] = await safe(superagent.get(`${settings.apiServerOrigin()}/api/v1/appupdate`) .query(query) .timeout(30 * 1000) .ok(() => true)); @@ -324,12 +310,11 @@ async function updateCloudron(data) { const token = await settings.getAppstoreApiToken(); if (!token) throw new BoxError(BoxError.LICENSE_ERROR, 'Missing token'); - const url = `${settings.apiServerOrigin()}/api/v1/update_cloudron`; const query = { accessToken: token }; - const [error, response] = await safe(superagent.post(url) + const [error, response] = await safe(superagent.post(`${settings.apiServerOrigin()}/api/v1/update_cloudron`) .query(query) .send(data) .timeout(30 * 1000) @@ -419,9 +404,7 @@ async function getApps() { const unstable = await settings.getUnstableAppsConfig(); - const url = `${settings.apiServerOrigin()}/api/v1/apps`; - - const [error, response] = await safe(superagent.get(url) + const [error, response] = await safe(superagent.get(`${settings.apiServerOrigin()}/api/v1/apps`) .query({ accessToken: token, boxVersion: constants.VERSION, unstable: unstable }) .timeout(30 * 1000) .ok(() => true));