move updater routes and settings under /api/v1/updater

src/test/settings-test.js

@@ -22,11 +22,6 @@ describe('Settings', function () {
         expect(tz.length).to.not.be(0);
     });
 
-    it('can get default autoupdate_pattern', async function () {
-        const pattern = await settings.getAutoupdatePattern();
-        expect(pattern).to.be('00 00 1,3,5,23 * * *');
-    });
-
     it('can get backup config', async function () {
         const backupConfig = await settings.getBackupConfig();
         expect(backupConfig.provider).to.be('filesystem');
@@ -64,6 +59,5 @@ describe('Settings', function () {
     it('can get all values', async function () {
         const allSettings = await settings.list();
         expect(allSettings[settings.TIME_ZONE_KEY]).to.be.a('string');
-        expect(allSettings[settings.AUTOUPDATE_PATTERN_KEY]).to.be.a('string');
     });
 });

src/test/updatechecker-test.js

@@ -12,8 +12,8 @@ const common = require('./common.js'),
     paths = require('../paths.js'),
     safe = require('safetydance'),
     semver = require('semver'),
-    settings = require('../settings.js'),
-    updatechecker = require('../updatechecker.js');
+    updatechecker = require('../updatechecker.js'),
+    updater = require('../updater.js');
 
 const UPDATE_VERSION = semver.inc(constants.VERSION, 'major');
 
@@ -27,7 +27,7 @@ describe('updatechecker', function () {
         before(async function () {
             safe.fs.unlinkSync(paths.UPDATE_CHECKER_FILE);
 
-            await settings.setAutoupdatePattern(constants.AUTOUPDATE_PATTERN_NEVER);
+            await updater.setAutoupdatePattern(constants.AUTOUPDATE_PATTERN_NEVER);
         });
 
         it('no updates', async function () {
@@ -76,7 +76,7 @@ describe('updatechecker', function () {
         before(async function () {
             safe.fs.unlinkSync(paths.UPDATE_CHECKER_FILE);
 
-            await settings.setAutoupdatePattern(constants.AUTOUPDATE_PATTERN_NEVER);
+            await updater.setAutoupdatePattern(constants.AUTOUPDATE_PATTERN_NEVER);
         });
 
         it('no updates', async function () {

src/test/updater-test.js

@@ -0,0 +1,33 @@
+/* global it:false */
+/* global describe:false */
+/* global before:false */
+/* global after:false */
+
+'use strict';
+
+const BoxError = require('../boxerror.js'),
+    common = require('./common.js'),
+    expect = require('expect.js'),
+    safe = require('safetydance'),
+    updater = require('../updater.js');
+
+describe('updater', function () {
+    const { setup, cleanup } = common;
+
+    before(setup);
+    after(cleanup);
+
+    it('can get default autoupdate_pattern', async function () {
+        const pattern = await updater.getAutoupdatePattern();
+        expect(pattern).to.be('00 00 1,3,5,23 * * *');
+    });
+
+    it('cannot set invalid autoupdate_pattern', async function () {
+        const [error] = await safe(updater.setAutoupdatePattern('02 * 1 *'));
+        expect(error.reason).to.be(BoxError.BAD_FIELD);
+    });
+
+    it('can set default autoupdate_pattern', async function () {
+        await updater.setAutoupdatePattern('02 * 1-5 * * *');
+    });
+});