From 531d314e25aa86afbc8b26a77f1f7e87f43fb6c8 Mon Sep 17 00:00:00 2001 From: Girish Ramakrishnan Date: Sat, 11 Apr 2020 14:52:09 -0700 Subject: [PATCH] Show error message if gpg failed --- src/updater.js | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/updater.js b/src/updater.js index 199f474b7..2c217fe33 100644 --- a/src/updater.js +++ b/src/updater.js @@ -64,13 +64,16 @@ function gpgVerify(file, sig, callback) { debug(`gpgVerify: ${cmd}`); child_process.exec(cmd, { encoding: 'utf8' }, function (error, stdout, stderr) { - if (error) return callback(new BoxError(BoxError.NOT_SIGNED, `The signature in ${path.basename(sig)} could not verified`)); + if (error) { + debug(`gpgVerify: command failed. error: ${error}\n stdout: ${stdout}\n stderr: ${stderr}`); + return callback(new BoxError(BoxError.NOT_SIGNED, `The signature in ${path.basename(sig)} could not verified (command failed)`)); + } if (stdout.indexOf('[GNUPG:] VALIDSIG 0EADB19CDDA23CD0FE71E3470A372F8703C493CC') !== -1) return callback(); debug(`gpgVerify: verification of ${sig} failed: ${stdout}\n${stderr}`); - return callback(new BoxError(BoxError.NOT_SIGNED, `The signature in ${path.basename(sig)} could not verified`)); + return callback(new BoxError(BoxError.NOT_SIGNED, `The signature in ${path.basename(sig)} could not verified (bad sig)`)); }); }