jjkiers/cloudron-box
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Send correct error message for dataDir conflict

Browse Source
This commit is contained in:
Girish Ramakrishnan
2019-01-19 21:07:21 -08:00
parent d8ff2488a3
commit 4b93d30ec0
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/apps.js
View File

@@ -327,21 +327,21 @@ function getDuplicateErrorDetails(location, portBindings, error) {
assert.strictEqual(typeof portBindings, 'object'); assert.strictEqual(typeof portBindings, 'object');
assert.strictEqual(error.reason, DatabaseError.ALREADY_EXISTS); assert.strictEqual(error.reason, DatabaseError.ALREADY_EXISTS);
var match = error.message.match(/ER_DUP_ENTRY: Duplicate entry '(.*)' for key/); var match = error.message.match(/ER_DUP_ENTRY: Duplicate entry '(.*)' for key '(.*)'/);
if (!match) { if (!match) {
debug('Unexpected SQL error message.', error); debug('Unexpected SQL error message.', error);
return new AppsError(AppsError.INTERNAL_ERROR); return new AppsError(AppsError.INTERNAL_ERROR, error);
} }
// check if the location conflicts // check if the location conflicts
if (match[1] === location) return new AppsError(AppsError.ALREADY_EXISTS); if (match[1] === location) return new AppsError(AppsError.ALREADY_EXISTS, `${match[2]} '${match[1]}' is in use`);
// check if any of the port bindings conflict // check if any of the port bindings conflict
for (let portName in portBindings) { for (let portName in portBindings) {
if (portBindings[portName] === parseInt(match[1])) return new AppsError(AppsError.PORT_CONFLICT, match[1]); if (portBindings[portName] === parseInt(match[1])) return new AppsError(AppsError.PORT_CONFLICT, match[1]);
} }
return new AppsError(AppsError.ALREADY_EXISTS); return new AppsError(AppsError.ALREADY_EXISTS, `${match[2]} '${match[1]}' is in use`);
} }
// app configs that is useful for 'archival' into the app backup config.json // app configs that is useful for 'archival' into the app backup config.json