firewall: syntax cleanup

setup/start/cloudron-firewall.sh

@@ -20,20 +20,18 @@ fi
 iptables -t filter -A CLOUDRON -m state --state RELATED,ESTABLISHED -j ACCEPT
 iptables -t filter -A CLOUDRON -p tcp -m tcp -m multiport --dports 22,25,80,202,443 -j ACCEPT # 202 is the alternate ssh port
 
-# whitelist any user ports
+# whitelist any user ports. we used to use --dports but it has a 15 port limit (XT_MULTI_PORTS)
 ports_json="/home/yellowtent/boxdata/firewall/ports.json"
 if allowed_tcp_ports=$(node -e "console.log(JSON.parse(fs.readFileSync('${ports_json}', 'utf8')).allowed_tcp_ports.join(','))" 2>/dev/null); then
-    IFS=',' arr=(${allowed_tcp_ports});
-    for p in "${arr[@]}"
-    do
+    IFS=',' arr=(${allowed_tcp_ports})
+    for p in "${arr[@]}"; do
         iptables -A CLOUDRON -p tcp -m tcp --dport "${p}" -j ACCEPT
     done
 fi
 
 if allowed_udp_ports=$(node -e "console.log(JSON.parse(fs.readFileSync('${ports_json}', 'utf8')).allowed_udp_ports.join(','))" 2>/dev/null); then
-    IFS=',' arr=(${allowed_udp_ports});
-    for p in "${arr[@]}"
-    do
+    IFS=',' arr=(${allowed_udp_ports})
+    for p in "${arr[@]}"; do
         iptables -A CLOUDRON -p udp -m udp --dport "${p}" -j ACCEPT
     done
 fi