Revert "Add no-use-before-define linter rule"

This reverts commit fdcc5d68a2.

Unfortunately, this requires us to move exports to the bottom.
This in turn causes circular dep issues and also access of
exports.GLOBAL_VAR in the global context

src/mail.js

@@ -1,5 +1,65 @@
 'use strict';
 
+exports = module.exports = {
+    getStatus,
+    checkConfiguration,
+
+    listDomains,
+
+    getDomain,
+    clearDomains,
+
+    removePrivateFields,
+
+    setDnsRecords,
+    upsertDnsRecords,
+
+    validateName,
+    validateDisplayName,
+
+    setMailFromValidation,
+    setCatchAllAddress,
+    setMailRelay,
+    setMailEnabled,
+    setBanner,
+
+    sendTestMail,
+
+    getMailboxCount,
+    listMailboxes,
+    listAllMailboxes,
+    getMailbox,
+    addMailbox,
+    updateMailbox,
+    delMailbox,
+
+    getAlias,
+    getAliases,
+    setAliases,
+    searchAlias,
+
+    getListCount,
+    getLists,
+    getList,
+    addList,
+    updateList,
+    delList,
+    resolveList,
+
+    checkStatus,
+
+    OWNERTYPE_USER: 'user',
+    OWNERTYPE_GROUP: 'group',
+    OWNERTYPE_APP: 'app',
+
+    TYPE_MAILBOX: 'mailbox',
+    TYPE_LIST: 'list',
+    TYPE_ALIAS: 'alias',
+
+    _delByDomain: delByDomain,
+    _updateDomain: updateDomain
+};
+
 const assert = require('node:assert'),
     BoxError = require('./boxerror.js'),
     constants = require('./constants.js'),
@@ -27,8 +87,6 @@ const assert = require('node:assert'),
 const DNS_OPTIONS = { timeout: 20000, tries: 4 };
 const REMOVE_MAILBOX_CMD = path.join(__dirname, 'scripts/rmmailbox.sh');
 
-const OWNERTYPES = [ exports.OWNERTYPE_USER, exports.OWNERTYPE_GROUP, exports.OWNERTYPE_APP ];
-
 // if you add a field here, listMailboxes has to be updated
 const MAILBOX_FIELDS = [ 'name', 'type', 'ownerId', 'ownerType', 'aliasName', 'aliasDomain', 'creationTime', 'membersJson', 'membersOnly', 'domain', 'active', 'enablePop3', 'storageQuota', 'messagesQuota' ].join(',');
 const MAILDB_FIELDS = [ 'domain', 'enabled', 'mailFromValidation', 'catchAllJson', 'relayJson', 'dkimKeyJson', 'dkimSelector', 'bannerJson' ].join(',');
@@ -111,6 +169,11 @@ function validateDisplayName(name) {
     return null;
 }
 
+function validateOwnerType(type) {
+    const OWNERTYPES = [ exports.OWNERTYPE_USER, exports.OWNERTYPE_GROUP, exports.OWNERTYPE_APP ];
+    return OWNERTYPES.includes(type);
+}
+
 async function getDomain(domain) {
     assert.strictEqual(typeof domain, 'string');
 
@@ -862,7 +925,7 @@ async function addMailbox(name, domain, data, auditSource) {
     let error = validateName(name);
     if (error) throw error;
 
-    if (!OWNERTYPES.includes(ownerType)) throw new BoxError(BoxError.BAD_FIELD, 'bad owner type');
+    if (!validateOwnerType(ownerType)) throw new BoxError(BoxError.BAD_FIELD, 'bad owner type');
 
     [error] = await safe(database.query('INSERT INTO mailboxes (name, type, domain, ownerId, ownerType, active, storageQuota, messagesQuota, enablePop3) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?)',
         [ name, exports.TYPE_MAILBOX, domain, ownerId, ownerType, active, storageQuota, messagesQuota, enablePop3 ]));
@@ -888,7 +951,7 @@ async function updateMailbox(name, domain, data, auditSource) {
             continue;
         }
 
-        if (k === 'ownerType' && !OWNERTYPES.includes(data[k])) throw new BoxError(BoxError.BAD_FIELD, 'bad owner type');
+        if (k === 'ownerType' && !validateOwnerType(data[k])) throw new BoxError(BoxError.BAD_FIELD, 'bad owner type');
 
         fields.push(k + ' = ?');
         args.push(data[k]);
@@ -1177,62 +1240,3 @@ async function checkStatus() {
     }
 }
 
-exports = module.exports = {
-    getStatus,
-    checkConfiguration,
-
-    listDomains,
-
-    getDomain,
-    clearDomains,
-
-    removePrivateFields,
-
-    setDnsRecords,
-    upsertDnsRecords,
-
-    validateName,
-    validateDisplayName,
-
-    setMailFromValidation,
-    setCatchAllAddress,
-    setMailRelay,
-    setMailEnabled,
-    setBanner,
-
-    sendTestMail,
-
-    getMailboxCount,
-    listMailboxes,
-    listAllMailboxes,
-    getMailbox,
-    addMailbox,
-    updateMailbox,
-    delMailbox,
-
-    getAlias,
-    getAliases,
-    setAliases,
-    searchAlias,
-
-    getListCount,
-    getLists,
-    getList,
-    addList,
-    updateList,
-    delList,
-    resolveList,
-
-    checkStatus,
-
-    OWNERTYPE_USER: 'user',
-    OWNERTYPE_GROUP: 'group',
-    OWNERTYPE_APP: 'app',
-
-    TYPE_MAILBOX: 'mailbox',
-    TYPE_LIST: 'list',
-    TYPE_ALIAS: 'alias',
-
-    _delByDomain: delByDomain,
-    _updateDomain: updateDomain
-};