From 42b65baa39a85a1a9ca357ec0061a882ba122e8a Mon Sep 17 00:00:00 2001
From: Girish Ramakrishnan
Date: Wed, 31 Aug 2016 07:46:00 -0700
Subject: [PATCH] Listen to mail config change event correctly
---
src/platform.js | 8 +++++---
webadmin/src/views/settings.html | 2 +-
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/src/platform.js b/src/platform.js
index 5398d3323..cb6297acd 100644
--- a/src/platform.js
+++ b/src/platform.js
@@ -34,11 +34,15 @@ var apps = require('./apps.js'),
var gAddonVars = null,
gPlatformReadyTimer = null;
+var NOOP_CALLBACK = function (error) { if (error) debug(error); };
+
function initialize(callback) {
if (process.env.BOX_ENV === 'test' && !process.env.CREATE_INFRA) return callback();
debug('initializing addon infrastructure');
+ settings.events.on(settings.MAIL_CONFIG_KEY, function () { startMail(NOOP_CALLBACK); });
+
var existingInfra = { version: 'none' };
if (fs.existsSync(paths.INFRA_VERSION_FILE)) {
existingInfra = safe.JSON.parse(fs.readFileSync(paths.INFRA_VERSION_FILE, 'utf8'));
@@ -74,8 +78,6 @@ function initialize(callback) {
exports.events.emit(exports.EVENT_READY);
}, 30000);
- settings.events.on(exports.MAIL_CONFIG_KEY, startMail);
-
callback();
});
}
@@ -83,7 +85,7 @@ function initialize(callback) {
function uninitialize(callback) {
clearTimeout(gPlatformReadyTimer);
gPlatformReadyTimer = null;
- settings.events.removeListener(exports.MAIL_CONFIG_KEY, startMail);
+ settings.events.removeListener(settings.MAIL_CONFIG_KEY, startMail);
callback();
}
diff --git a/webadmin/src/views/settings.html b/webadmin/src/views/settings.html
index 8b215be9d..1e96af6e5 100644
--- a/webadmin/src/views/settings.html
+++ b/webadmin/src/views/settings.html
@@ -199,7 +199,7 @@
Email server can only be enabled for custom domains.
-
+