From 409e4beaaa473a6e18d3f2b316351cc673e4e563 Mon Sep 17 00:00:00 2001
From: Girish Ramakrishnan <girish@cloudron.io>
Date: Mon, 26 Oct 2020 10:04:19 -0700
Subject: [PATCH] rsync: Add warning to remove s3 life cycle rules

---
 src/views/backups.html | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/views/backups.html b/src/views/backups.html
index ac43d6fac..458a85062 100644
--- a/src/views/backups.html
+++ b/src/views/backups.html
@@ -256,6 +256,7 @@
             <div class="form-group" ng-show="configureBackup.provider !== 'noop'">
               <label class="control-label" for="storageFormat">Storage Format  <sup><a ng-href="https://docs.cloudron.io/backups/#backup-formats" class="help" target="_blank"><i class="fa fa-question-circle"></i></a></sup></label>
               <p class="small text-info" ng-show="backupConfig.format !== configureBackup.format">Previous backups using the old storage format have to be removed manually.</p>
+              <p class="small text-info" ng-show="configureBackup.format === 'rsync' && (s3like(configureBackup.provider) || configureBackup.provider === 'gcs')">Please remove any object expiration lifecycle rules since it will corrupt rsync backups. <sup><a ng-href="https://docs.cloudron.io/backups/#amazon-s3" class="help" target="_blank"><i class="fa fa-question-circle"></i></a></sup></p>
               <select class="form-control" id="storageFormat" ng-model="configureBackup.format" ng-options="a.value as a.name for a in formats"></select>
             </div>