Make more use of app state variables

This commit is contained in:
Johannes Zellner
2022-09-13 11:44:54 +02:00
parent 403a96162b
commit 4046da9368
2 changed files with 20 additions and 19 deletions

View File

@@ -81,23 +81,24 @@ angular.module('Application').controller('AppsController', ['$scope', '$translat
$event.originalEvent.preventDefault();
}
if (app.installationState === ISTATES.ERROR) {
if ($scope.isOperator(app)) $scope.showAppConfigure(app, 'repair');
if (app.installationState !== ISTATES.INSTALLED) {
if (app.installationState === ISTATES.ERROR && $scope.isOperator(app)) $scope.showAppConfigure(app, 'repair');
return stopEvent();
} else if (app.installationState === ISTATES.INSTALLED) {
// app.health can also be null to indicate insufficient data
if (app.runState === RSTATES.STOPPED) return stopEvent();
}
if (app.health === HSTATES.UNHEALTHY || app.health === HSTATES.ERROR || app.health === HSTATES.DEAD) {
if ($scope.isOperator(app)) $scope.showAppConfigure(app, 'repair');
return stopEvent();
}
// app.health can also be null to indicate insufficient data
if (!app.health) return stopEvent();
if (app.runState === RSTATES.STOPPED) return stopEvent();
if (app.runState === RSTATES.STOPPED) return stopEvent();
if (app.pendingPostInstallConfirmation) {
$scope.appPostInstallConfirm.show(app);
return stopEvent();
}
if (app.health === HSTATES.UNHEALTHY || app.health === HSTATES.ERROR || app.health === HSTATES.DEAD) {
if ($scope.isOperator(app)) $scope.showAppConfigure(app, 'repair');
return stopEvent();
}
if (app.pendingPostInstallConfirmation) {
$scope.appPostInstallConfirm.show(app);
return stopEvent();
}
};