Fix form validation for external domains

This commit is contained in:
Johannes Zellner
2017-05-03 15:25:24 +02:00
parent be5221d5b8
commit 3e6295de92
3 changed files with 6 additions and 6 deletions
+3 -3
View File
@@ -8,9 +8,9 @@ angular.module('ngTld', [])
.directive('checkTld', checkTld);
function ngTld() {
function tldExists(path) {
function isValid(path) {
// https://github.com/oncletom/tld.js/issues/58
return (path.slice(-1) !== '.') && path === tld.getDomain(path);
return (path.slice(-1) !== '.') && tld.isValid(path);
}
function isSubdomain(path) {
@@ -22,7 +22,7 @@ function ngTld() {
}
return {
tldExists: tldExists,
isValid: isValid,
isSubdomain: isSubdomain,
isNakedDomain: isNakedDomain
};
+2 -2
View File
@@ -178,14 +178,14 @@
</div>
<input type="password" class="form-control" ng-model="appConfigure.password" id="appConfigurePasswordInput" name="password" required>
</div>
<input class="ng-hide" type="submit" ng-disabled="appConfigureForm.$invalid || busy || (appConfigure.accessRestrictionOption === 'groups' && !appConfigure.isAccessRestrictionValid())"/>
<input class="ng-hide" type="submit" ng-disabled="appConfigureForm.$invalid || appConfigure.busy || (appConfigure.accessRestrictionOption === 'groups' && !appConfigure.isAccessRestrictionValid()) || (appConfigure.usingAltDomain && !appConfigure.isAltDomainValid())"/>
</form>
</fieldset>
</div>
<div class="modal-footer ">
<button type="button" class="btn btn-default pull-left" ng-click="restartApp(appConfigure.app)" ng-disabled="restartAppBusy"><i class="fa fa-circle-o-notch fa-spin" ng-show="restartAppBusy"></i> Restart</button>
<button type="button" class="btn btn-default" data-dismiss="modal">Cancel</button>
<button type="button" class="btn btn-success" ng-click="doConfigure()" ng-disabled="appConfigureForm.$invalid || appConfigure.busy || (appConfigure.accessRestrictionOption === 'groups' && !appConfigure.isAccessRestrictionValid()) || !appConfigure.isAltDomainValid()"><i class="fa fa-circle-o-notch fa-spin" ng-show="appConfigure.busy"></i> Save</button>
<button type="button" class="btn btn-success" ng-click="doConfigure()" ng-disabled="appConfigureForm.$invalid || appConfigure.busy || (appConfigure.accessRestrictionOption === 'groups' && !appConfigure.isAccessRestrictionValid()) || (appConfigure.usingAltDomain && !appConfigure.isAltDomainValid())"><i class="fa fa-circle-o-notch fa-spin" ng-show="appConfigure.busy"></i> Save</button>
</div>
</div>
</div>
+1 -1
View File
@@ -42,7 +42,7 @@ angular.module('Application').controller('AppsController', ['$scope', '$location
},
isAltDomainValid: function () {
return ngTld.tldExists($scope.appConfigure.location);
return ngTld.isValid($scope.appConfigure.location);
},
isAltDomainSubdomain: function () {