diff --git a/src/apptask.js b/src/apptask.js index 3eeb5d414..aa86f3249 100644 --- a/src/apptask.js +++ b/src/apptask.js @@ -218,7 +218,7 @@ function registerSubdomain(app, overwrite, callback) { assert.strictEqual(typeof overwrite, 'boolean'); assert.strictEqual(typeof callback, 'function'); - sysinfo.getIp(function (error, ip) { + sysinfo.getPublicIp(function (error, ip) { if (error) return callback(error); async.retry({ times: 200, interval: 5000 }, function (retryCallback) { @@ -257,7 +257,7 @@ function unregisterSubdomain(app, location, callback) { return callback(null); } - sysinfo.getIp(function (error, ip) { + sysinfo.getPublicIp(function (error, ip) { if (error) return callback(error); async.retry({ times: 30, interval: 5000 }, function (retryCallback) { @@ -295,7 +295,7 @@ function waitForDnsPropagation(app, callback) { return callback(null); } - sysinfo.getIp(function (error, ip) { + sysinfo.getPublicIp(function (error, ip) { if (error) return callback(error); subdomains.waitForDns(config.appFqdn(app.location), ip, 'A', { interval: 5000, times: 120 }, callback); diff --git a/src/cloudron.js b/src/cloudron.js index e944a8bb8..32ceefe7e 100644 --- a/src/cloudron.js +++ b/src/cloudron.js @@ -264,7 +264,7 @@ function configureAdmin(callback) { debug('configureAdmin'); - sysinfo.getIp(function (error, ip) { + sysinfo.getPublicIp(function (error, ip) { if (error) return callback(error); subdomains.waitForDns(config.adminFqdn(), ip, 'A', { interval: 30000, times: 50000 }, function (error) { @@ -621,7 +621,7 @@ function addDnsRecords(callback) { var dkimKey = readDkimPublicKeySync(); if (!dkimKey) return callback(new CloudronError(CloudronError.INTERNAL_ERROR, new Error('Failed to read dkim public key'))); - sysinfo.getIp(function (error, ip) { + sysinfo.getPublicIp(function (error, ip) { if (error) return callback(new CloudronError(CloudronError.INTERNAL_ERROR, error)); var webadminRecord = { subdomain: constants.ADMIN_LOCATION, type: 'A', values: [ ip ] }; @@ -957,7 +957,7 @@ function migrate(options, callback) { function refreshDNS(callback) { callback = callback || NOOP_CALLBACK; - sysinfo.getIp(function (error, ip) { + sysinfo.getPublicIp(function (error, ip) { if (error) return callback(new CloudronError(CloudronError.INTERNAL_ERROR, error)); debug('refreshDNS: current ip %s', ip); diff --git a/src/settings.js b/src/settings.js index 876495964..249b376b4 100644 --- a/src/settings.js +++ b/src/settings.js @@ -260,7 +260,7 @@ function getEmailDnsRecords(callback) { status: false }; - sysinfo.getIp(function (error, ip) { + sysinfo.getPublicIp(function (error, ip) { if (error) return callback(error); records.ptr.domain = ip.split('.').reverse().join('.') + '.in-addr.arpa'; @@ -453,7 +453,7 @@ function setDnsConfig(dnsConfig, domain, callback) { assert.strictEqual(typeof domain, 'string'); assert.strictEqual(typeof callback, 'function'); - sysinfo.getIp(function (error, ip) { + sysinfo.getPublicIp(function (error, ip) { if (error) return callback(new SettingsError(SettingsError.INTERNAL_ERROR, 'Error getting IP:' + error.message)); subdomains.verifyDnsConfig(dnsConfig, domain, ip, function (error, result) { diff --git a/src/sysinfo.js b/src/sysinfo.js index a5c452635..b0a3f6452 100644 --- a/src/sysinfo.js +++ b/src/sysinfo.js @@ -3,7 +3,7 @@ exports = module.exports = { SysInfoError: SysInfoError, - getIp: getIp + getPublicIp: getPublicIp }; var assert = require('assert'), @@ -49,12 +49,12 @@ function getApi(callback) { } } -function getIp(callback) { +function getPublicIp(callback) { assert.strictEqual(typeof callback, 'function'); getApi(function (error, api) { if (error) return callback(error); - api.getIp(callback); + api.getPublicIp(callback); }); } diff --git a/src/sysinfo/caas.js b/src/sysinfo/caas.js index fe1d2c9de..7d75b1de0 100644 --- a/src/sysinfo/caas.js +++ b/src/sysinfo/caas.js @@ -1,7 +1,7 @@ 'use strict'; exports = module.exports = { - getIp: getIp + getPublicIp: getPublicIp }; var assert = require('assert'), @@ -9,7 +9,7 @@ var assert = require('assert'), safe = require('safetydance'), SysInfoError = require('../sysinfo.js').SysInfoError; -function getIp(callback) { +function getPublicIp(callback) { assert.strictEqual(typeof callback, 'function'); if (process.env.BOX_ENV === 'test') return callback(null, '127.0.0.1'); diff --git a/src/sysinfo/ec2.js b/src/sysinfo/ec2.js index c0ff9ab91..256c775ef 100644 --- a/src/sysinfo/ec2.js +++ b/src/sysinfo/ec2.js @@ -1,7 +1,7 @@ 'use strict'; exports = module.exports = { - getIp: getIp + getPublicIp: getPublicIp }; var assert = require('assert'), @@ -9,7 +9,7 @@ var assert = require('assert'), SysInfoError = require('../sysinfo.js').SysInfoError, util = require('util'); -function getIp(callback) { +function getPublicIp(callback) { assert.strictEqual(typeof callback, 'function'); superagent.get('http://169.254.169.254/latest/meta-data/public-ipv4').timeout(30 * 1000).end(function (error, result) { diff --git a/src/sysinfo/generic.js b/src/sysinfo/generic.js index d63421ffd..38165f19c 100644 --- a/src/sysinfo/generic.js +++ b/src/sysinfo/generic.js @@ -1,7 +1,7 @@ 'use strict'; exports = module.exports = { - getIp: getIp + getPublicIp: getPublicIp }; var assert = require('assert'), @@ -10,7 +10,7 @@ var assert = require('assert'), superagent = require('superagent'), SysInfoError = require('../sysinfo.js').SysInfoError; -function getIp(callback) { +function getPublicIp(callback) { assert.strictEqual(typeof callback, 'function'); async.retry({ times: 10, interval: 5000 }, function (callback) { diff --git a/src/sysinfo/interface.js b/src/sysinfo/interface.js index 74ad6aff4..8cc7905de 100644 --- a/src/sysinfo/interface.js +++ b/src/sysinfo/interface.js @@ -7,12 +7,12 @@ // ------------------------------------------- exports = module.exports = { - getIp: getIp + getPublicIp: getPublicIp }; var assert = require('assert'); -function getIp(callback) { +function getPublicIp(callback) { assert.strictEqual(typeof callback, 'function'); callback(new Error('not implemented')); diff --git a/src/sysinfo/scaleway.js b/src/sysinfo/scaleway.js index 09b89f097..de6fcd984 100644 --- a/src/sysinfo/scaleway.js +++ b/src/sysinfo/scaleway.js @@ -1,13 +1,13 @@ 'use strict'; exports = module.exports = { - getIp: getIp + getPublicIp: getPublicIp }; var assert = require('assert'), superagent = require('superagent'); -function getIp(callback) { +function getPublicIp(callback) { assert.strictEqual(typeof callback, 'function'); superagent.get('http://169.254.42.42/conf').timeout(30 * 1000).end(function (error, result) {