move server routes into /system

src/routes/test/cloudron-test.js

@@ -8,16 +8,11 @@
 const constants = require('../../constants.js'),
     common = require('./common.js'),
     expect = require('expect.js'),
-    fs = require('fs'),
-    http = require('http'),
-    os = require('os'),
-    paths = require('../../paths.js'),
-    safe = require('safetydance'),
     superagent = require('superagent'),
     settings = require('../../settings.js');
 
 describe('Cloudron API', function () {
-    const { setup, cleanup, serverUrl, owner, user, waitForTask } = common;
+    const { setup, cleanup, serverUrl, owner, user } = common;
 
     before(setup);
     after(cleanup);
@@ -300,136 +295,6 @@ describe('Cloudron API', function () {
         });
     });
 
-    describe('logs', function () {
-        before(function () {
-            console.log(paths.BOX_LOG_FILE);
-            fs.writeFileSync(paths.BOX_LOG_FILE, '2022-11-06T15:06:20.009Z box:apphealthmonitor app health: 0 alive / 0 dead.\n', 'utf8');
-        });
-
-        it('logStream - requires event-stream accept header', async function () {
-            const response = await superagent.get(`${serverUrl}/api/v1/cloudron/logstream/box`)
-                .query({ access_token: owner.token, fromLine: 0 })
-                .ok(() => true);
-
-            expect(response.statusCode).to.be(400);
-        });
-
-        it('logStream - stream logs', function (done) {
-            const options = {
-                host: 'localhost',
-                port: constants.PORT,
-                path: '/api/v1/cloudron/logstream/box?lines=10&access_token=' + owner.token,
-                headers: { 'Accept': 'text/event-stream', 'Connection': 'keep-alive' }
-            };
-
-            // superagent doesn't work. maybe https://github.com/visionmedia/superagent/issues/420
-            const req = http.get(options, function (res) {
-                let data = '';
-                res.on('data', function (d) { data += d.toString('utf8'); });
-                setTimeout(function checkData() {
-                    let dataMessageFound = false;
-
-                    expect(data.length).to.not.be(0);
-                    data.split('\n').forEach(function (line) {
-                        if (line.indexOf('id: ') === 0) {
-                            expect(parseInt(line.substr('id: '.length), 10)).to.be.a('number');
-                        } else if (line.indexOf('data: ') === 0) {
-                            const message = JSON.parse(line.slice('data: '.length)).message;
-                            if (Array.isArray(message) || typeof message === 'string') dataMessageFound = true;
-                        }
-                    });
-
-                    expect(dataMessageFound).to.be.ok();
-
-                    res.destroy();
-                    req.destroy();
-                    done();
-                }, 1000);
-                res.on('error', done);
-            });
-
-            req.on('error', done);
-        });
-    });
-
-    describe('memory', function () {
-        it('cannot get without token', async function () {
-            const response = await superagent.get(`${serverUrl}/api/v1/cloudron/memory`)
-                .ok(() => true);
-
-            expect(response.statusCode).to.equal(401);
-        });
-
-        it('succeeds (admin)', async function () {
-            const response = await superagent.get(`${serverUrl}/api/v1/cloudron/memory`)
-                .query({ access_token: owner.token });
-
-            expect(response.statusCode).to.equal(200);
-            expect(response.body.memory).to.eql(os.totalmem());
-            expect(response.body.swap).to.be.a('number');
-        });
-
-        it('fails (non-admin)', async function () {
-            const response = await superagent.get(`${serverUrl}/api/v1/cloudron/memory`)
-                .query({ access_token: user.token })
-                .ok(() => true);
-
-            expect(response.statusCode).to.equal(403);
-        });
-    });
-
-    describe('disks', function () {
-        it('succeeds', async function () {
-            const response = await superagent.get(`${serverUrl}/api/v1/cloudron/disks`)
-                .query({ access_token: owner.token });
-
-            expect(response.statusCode).to.equal(200);
-            expect(response.body.disks).to.be.ok();
-            expect(Object.keys(response.body.disks).some(fs => response.body.disks[fs].mountpoint === '/')).to.be(true);
-        });
-    });
-
-    describe('disk usage', function () {
-        it('get succeeds with no cache', async function () {
-            safe.fs.unlinkSync(paths.DISK_USAGE_FILE);
-
-            const response = await superagent.get(`${serverUrl}/api/v1/cloudron/disk_usage`)
-                .query({ access_token: owner.token })
-                .send({});
-
-            expect(response.statusCode).to.equal(200);
-            expect(response.body).to.eql({ usage: null });
-        });
-
-        it('update the cache', async function () {
-            const response = await superagent.post(`${serverUrl}/api/v1/cloudron/disk_usage`)
-                .query({ access_token: owner.token });
-
-            expect(response.statusCode).to.equal(201);
-            expect(response.body.taskId).to.be.ok();
-            await waitForTask(response.body.taskId);
-        });
-
-        it('get succeeds with cache', async function () {
-            const response = await superagent.get(`${serverUrl}/api/v1/cloudron/disk_usage`)
-                .query({ access_token: owner.token })
-                .send({});
-
-            expect(response.statusCode).to.equal(200);
-            expect(response.body.usage.ts).to.be.a('number');
-
-            const filesystems = Object.keys(response.body.usage.disks);
-            let dockerUsage = null;
-            for (const fs of filesystems) {
-                for (const content of response.body.usage.disks[fs].contents) {
-                    if (content.id === 'docker') dockerUsage = content;
-                }
-            }
-            expect(dockerUsage).to.be.ok();
-            expect(dockerUsage.usage).to.be.a('number');
-        });
-    });
-
     describe('languages', function () {
         it('succeeds', async function () {
             const response = await superagent.get(`${serverUrl}/api/v1/cloudron/languages`);
@@ -439,103 +304,4 @@ describe('Cloudron API', function () {
             expect(response.body.languages.indexOf('en')).to.not.equal(-1);
         });
     });
-
-    describe('blockdevices', function () {
-        it('succeeds', async function () {
-            const response = await superagent.get(`${serverUrl}/api/v1/cloudron/block_devices`)
-                .query({ access_token: owner.token });
-
-            expect(response.statusCode).to.equal(200);
-            expect(response.body.devices).to.be.ok();
-
-            expect(response.body.devices.some(d => d.mountpoint === '/')).to.be(true);
-        });
-    });
-
-    describe('time_zone', function () {
-        it('succeeds', async function () {
-            const response = await superagent.get(`${serverUrl}/api/v1/cloudron/time_zone`)
-                .query({ access_token: owner.token });
-            expect(response.statusCode).to.equal(200);
-            expect(response.body.timeZone).to.be('UTC');
-        });
-
-        it('cannot set tz with missing timeZone', async function () {
-            const response = await superagent.post(`${serverUrl}/api/v1/cloudron/time_zone`)
-                .query({ access_token: owner.token })
-                .send({ foo: 'bar' })
-                .ok(() => true);
-
-            expect(response.statusCode).to.equal(400);
-        });
-
-        it('cannot set language with invalid timeZone', async function () {
-            const response = await superagent.post(`${serverUrl}/api/v1/cloudron/time_zone`)
-                .query({ access_token: owner.token })
-                .send({ timeZone: 'doesnotexist' })
-                .ok(() => true);
-
-            expect(response.statusCode).to.equal(400);
-        });
-
-        it('can set time zone', async function () {
-            const response = await superagent.post(`${serverUrl}/api/v1/cloudron/time_zone`)
-                .query({ access_token: owner.token })
-                .send({ timeZone: 'Africa/Johannesburg' });
-
-            expect(response.statusCode).to.equal(200);
-        });
-
-        it('did set time zone', async function () {
-            const response = await superagent.get(`${serverUrl}/api/v1/cloudron/time_zone`)
-                .query({ access_token: owner.token });
-
-            expect(response.statusCode).to.equal(200);
-            expect(response.body.timeZone).to.equal('Africa/Johannesburg');
-        });
-    });
-
-    describe('language', function () {
-        it('can get default language', async function () {
-            const response = await superagent.get(`${serverUrl}/api/v1/cloudron/language`)
-                .query({ access_token: owner.token });
-
-            expect(response.statusCode).to.equal(200);
-            expect(response.body.language).to.equal('en');
-        });
-
-        it('cannot set language with missing language', async function () {
-            const response = await superagent.post(`${serverUrl}/api/v1/cloudron/language`)
-                .query({ access_token: owner.token })
-                .send({ foo: 'bar' })
-                .ok(() => true);
-
-            expect(response.statusCode).to.equal(400);
-        });
-
-        it('cannot set language with invalid language', async function () {
-            const response = await superagent.post(`${serverUrl}/api/v1/cloudron/language`)
-                .query({ access_token: owner.token })
-                .send({ language: 'doesnotexist' })
-                .ok(() => true);
-
-            expect(response.statusCode).to.equal(400);
-        });
-
-        it('can set language', async function () {
-            const response = await superagent.post(`${serverUrl}/api/v1/cloudron/language`)
-                .query({ access_token: owner.token })
-                .send({ language: 'de' });
-
-            expect(response.statusCode).to.equal(200);
-        });
-
-        it('did set language', async function () {
-            const response = await superagent.get(`${serverUrl}/api/v1/cloudron/language`)
-                .query({ access_token: owner.token });
-
-            expect(response.statusCode).to.equal(200);
-            expect(response.body.language).to.equal('de');
-        });
-    });
 });

src/routes/test/system-test.js

@@ -0,0 +1,165 @@
+'use strict';
+
+/* global it:false */
+/* global describe:false */
+/* global before:false */
+/* global after:false */
+
+const constants = require('../../constants.js'),
+    common = require('./common.js'),
+    expect = require('expect.js'),
+    fs = require('fs'),
+    http = require('http'),
+    os = require('os'),
+    paths = require('../../paths.js'),
+    safe = require('safetydance'),
+    superagent = require('superagent');
+
+describe('Cloudron API', function () {
+    const { setup, cleanup, serverUrl, owner, user, waitForTask } = common;
+
+    before(setup);
+    after(cleanup);
+
+    describe('logs', function () {
+        before(function () {
+            console.log(paths.BOX_LOG_FILE);
+            fs.writeFileSync(paths.BOX_LOG_FILE, '2022-11-06T15:06:20.009Z box:apphealthmonitor app health: 0 alive / 0 dead.\n', 'utf8');
+        });
+
+        it('logStream - requires event-stream accept header', async function () {
+            const response = await superagent.get(`${serverUrl}/api/v1/system/logstream/box`)
+                .query({ access_token: owner.token, fromLine: 0 })
+                .ok(() => true);
+
+            expect(response.statusCode).to.be(400);
+        });
+
+        it('logStream - stream logs', function (done) {
+            const options = {
+                host: 'localhost',
+                port: constants.PORT,
+                path: '/api/v1/system/logstream/box?lines=10&access_token=' + owner.token,
+                headers: { 'Accept': 'text/event-stream', 'Connection': 'keep-alive' }
+            };
+
+            // superagent doesn't work. maybe https://github.com/visionmedia/superagent/issues/420
+            const req = http.get(options, function (res) {
+                let data = '';
+                res.on('data', function (d) { data += d.toString('utf8'); });
+                setTimeout(function checkData() {
+                    let dataMessageFound = false;
+
+                    expect(data.length).to.not.be(0);
+                    data.split('\n').forEach(function (line) {
+                        if (line.indexOf('id: ') === 0) {
+                            expect(parseInt(line.substr('id: '.length), 10)).to.be.a('number');
+                        } else if (line.indexOf('data: ') === 0) {
+                            const message = JSON.parse(line.slice('data: '.length)).message;
+                            if (Array.isArray(message) || typeof message === 'string') dataMessageFound = true;
+                        }
+                    });
+
+                    expect(dataMessageFound).to.be.ok();
+
+                    res.destroy();
+                    req.destroy();
+                    done();
+                }, 1000);
+                res.on('error', done);
+            });
+
+            req.on('error', done);
+        });
+    });
+
+    describe('memory', function () {
+        it('cannot get without token', async function () {
+            const response = await superagent.get(`${serverUrl}/api/v1/system/memory`)
+                .ok(() => true);
+
+            expect(response.statusCode).to.equal(401);
+        });
+
+        it('succeeds (admin)', async function () {
+            const response = await superagent.get(`${serverUrl}/api/v1/system/memory`)
+                .query({ access_token: owner.token });
+
+            expect(response.statusCode).to.equal(200);
+            expect(response.body.memory).to.eql(os.totalmem());
+            expect(response.body.swap).to.be.a('number');
+        });
+
+        it('fails (non-admin)', async function () {
+            const response = await superagent.get(`${serverUrl}/api/v1/system/memory`)
+                .query({ access_token: user.token })
+                .ok(() => true);
+
+            expect(response.statusCode).to.equal(403);
+        });
+    });
+
+    describe('disks', function () {
+        it('succeeds', async function () {
+            const response = await superagent.get(`${serverUrl}/api/v1/system/disks`)
+                .query({ access_token: owner.token });
+
+            expect(response.statusCode).to.equal(200);
+            expect(response.body.disks).to.be.ok();
+            expect(Object.keys(response.body.disks).some(fs => response.body.disks[fs].mountpoint === '/')).to.be(true);
+        });
+    });
+
+    describe('disk usage', function () {
+        it('get succeeds with no cache', async function () {
+            safe.fs.unlinkSync(paths.DISK_USAGE_FILE);
+
+            const response = await superagent.get(`${serverUrl}/api/v1/system/disk_usage`)
+                .query({ access_token: owner.token })
+                .send({});
+
+            expect(response.statusCode).to.equal(200);
+            expect(response.body).to.eql({ usage: null });
+        });
+
+        it('update the cache', async function () {
+            const response = await superagent.post(`${serverUrl}/api/v1/system/disk_usage`)
+                .query({ access_token: owner.token });
+
+            expect(response.statusCode).to.equal(201);
+            expect(response.body.taskId).to.be.ok();
+            await waitForTask(response.body.taskId);
+        });
+
+        it('get succeeds with cache', async function () {
+            const response = await superagent.get(`${serverUrl}/api/v1/system/disk_usage`)
+                .query({ access_token: owner.token })
+                .send({});
+
+            expect(response.statusCode).to.equal(200);
+            expect(response.body.usage.ts).to.be.a('number');
+
+            const filesystems = Object.keys(response.body.usage.disks);
+            let dockerUsage = null;
+            for (const fs of filesystems) {
+                for (const content of response.body.usage.disks[fs].contents) {
+                    if (content.id === 'docker') dockerUsage = content;
+                }
+            }
+            expect(dockerUsage).to.be.ok();
+            expect(dockerUsage.usage).to.be.a('number');
+        });
+    });
+
+    describe('blockdevices', function () {
+        it('succeeds', async function () {
+            const response = await superagent.get(`${serverUrl}/api/v1/system/block_devices`)
+                .query({ access_token: owner.token });
+
+            expect(response.statusCode).to.equal(200);
+            expect(response.body.devices).to.be.ok();
+
+            expect(response.body.devices.some(d => d.mountpoint === '/')).to.be(true);
+        });
+    });
+});