fix the backup tests

src/test/storage-test.js

@@ -5,7 +5,8 @@
 
 'use strict';
 
-var BoxError = require('../boxerror.js'),
+const BoxError = require('../boxerror.js'),
+    common = require('./common.js'),
     execSync = require('child_process').execSync,
     expect = require('expect.js'),
     filesystem = require('../storage/filesystem.js'),
@@ -17,19 +18,26 @@ var BoxError = require('../boxerror.js'),
     rimraf = require('rimraf'),
     recursive_readdir = require('recursive-readdir'),
     s3 = require('../storage/s3.js'),
+    settings = require('../settings.js'),
     gcs = require('../storage/gcs.js'),
     chunk = require('lodash.chunk');
 
 describe('Storage', function () {
+    const { setup, cleanup } = common;
+
+    before(setup);
+    after(cleanup);
+
     describe('filesystem', function () {
+        let gTmpFolder;
 
-        var gTmpFolder;
-
-        var gBackupConfig = {
+        const gBackupConfig = {
             provider: 'filesystem',
             key: 'key',
             backupFolder: null,
-            format: 'tgz'
+            format: 'tgz',
+            retentionPolicy: { keepWithinSecs: 10000 },
+            schedulePattern: '00 00 23 * * *'
         };
 
         before(function (done) {
@@ -45,6 +53,26 @@ describe('Storage', function () {
             done();
         });
 
+        it('fails to set backup config for bad folder', function (done) {
+            const tmp = Object.assign({}, gBackupConfig, { backupFolder: '/root/oof' });
+            settings.setBackupConfig(tmp, function (error) {
+                expect(error).to.be.a(BoxError);
+                expect(error.reason).to.equal(BoxError.BAD_FIELD);
+
+                done();
+            });
+        });
+
+        it('succeeds to set backup config', function (done) {
+            settings.setBackupConfig(gBackupConfig, function (error) {
+                expect(error).to.be(null);
+
+                expect(fs.existsSync(path.join(gBackupConfig.backupFolder, 'snapshot'))).to.be(true); // auto-created
+
+                done();
+            });
+        });
+
         it('can upload', function (done) {
             var sourceFile = path.join(__dirname, 'storage/data/test.txt');
             var sourceStream = fs.createReadStream(sourceFile);