add tests for storage backends

src/storage/filesystem.js

@@ -86,7 +86,7 @@ function downloadDir(apiConfig, backupFilePath, destDir, callback) {
     shell.exec('downloadDir', '/bin/cp', [ '-r', backupFilePath + '/.', destDir ], { }, function (error) {
         if (error) return callback(new BackupsError(BackupsError.EXTERNAL_ERROR, error.message));
 
-        callback();
+        callback(null);
     });
 }
 
@@ -105,7 +105,7 @@ function copy(apiConfig, oldFilePath, newFilePath, callback) {
         shell.exec('copy', '/bin/cp', [ '-al', oldFilePath, newFilePath ], { }, function (error) {
             if (error) return callback(new BackupsError(BackupsError.EXTERNAL_ERROR, error.message));
 
-            callback();
+            callback(null);
         });
     });
 }
@@ -124,7 +124,7 @@ function remove(apiConfig, filename, callback) {
         if (!safe.fs.rmdirSync(filename)) return callback(new BackupsError(BackupsError.EXTERNAL_ERROR, safe.error.message));
     }
 
-    callback();
+    callback(null);
 }
 
 function removeDir(apiConfig, pathPrefix, callback) {
@@ -135,7 +135,7 @@ function removeDir(apiConfig, pathPrefix, callback) {
     shell.exec('removeDir', '/bin/rm', [ '-rf', pathPrefix ], { }, function (error) {
         if (error) return callback(new BackupsError(BackupsError.EXTERNAL_ERROR, error.message));
 
-        callback();
+        callback(null);
     });
 }
 

src/storage/noop.js

@@ -25,7 +25,7 @@ function upload(apiConfig, backupFilePath, sourceStream, callback) {
 
     debug('upload: %s', backupFilePath);
 
-    callback();
+    callback(null);
 }
 
 function download(apiConfig, backupFilePath, callback) {
@@ -46,7 +46,7 @@ function downloadDir(apiConfig, backupFilePath, destDir, callback) {
 
     debug('downloadDir: %s -> %s', backupFilePath, destDir);
 
-    callback();
+    callback(new Error('Cannot download from noop backend'));
 }
 
 function copy(apiConfig, oldFilePath, newFilePath, callback) {
@@ -57,7 +57,7 @@ function copy(apiConfig, oldFilePath, newFilePath, callback) {
 
     debug('copy: %s -> %s', oldFilePath, newFilePath);
 
-    callback();
+    callback(null);
 }
 
 function remove(apiConfig, filename, callback) {
@@ -67,7 +67,7 @@ function remove(apiConfig, filename, callback) {
 
     debug('remove: %s', filename);
 
-    callback();
+    callback(null);
 }
 
 function removeDir(apiConfig, pathPrefix, callback) {
@@ -77,14 +77,14 @@ function removeDir(apiConfig, pathPrefix, callback) {
 
     debug('removeDir: %s', pathPrefix);
 
-    callback();
+    callback(null);
 }
 
 function testConfig(apiConfig, callback) {
     assert.strictEqual(typeof apiConfig, 'object');
     assert.strictEqual(typeof callback, 'function');
 
-    callback();
+    callback(null);
 }
 
 function backupDone(apiConfig, backupId, appBackupIds, callback) {
@@ -93,5 +93,5 @@ function backupDone(apiConfig, backupId, appBackupIds, callback) {
     assert(Array.isArray(appBackupIds));
     assert.strictEqual(typeof callback, 'function');
 
-    callback();
+    callback(null);
 }

src/storage/s3.js

@@ -189,7 +189,7 @@ function listDir(apiConfig, backupFilePath, options, iteratorCallback, callback)
                 });
             });
         }, function (error) {
-            if (error.message === 'Done') return callback();
+            if (error.message === 'Done') return callback(null);
 
             callback(error);
         });