jjkiers/cloudron-box
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Fix certificate ordering logic

Browse Source 
* app certs set by user are always preferred
* If fallback, choose fallback certs. ignore others
* If LE, try to pick LE certs. Otherwise, provider fallback.

Fixes #724
This commit is contained in:
Girish Ramakrishnan
2020-08-07 22:59:57 -07:00
parent 60b3fceea6
commit 1f1c94de70
5 changed files with 41 additions and 70 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/test/reverseproxy-test.js
View File

@@ -193,7 +193,7 @@ describe('Certificates', function () {
after(cleanup);
it('returns prod acme in prod cloudron', function (done) {
reverseProxy._getCertApi(DOMAIN_0, function (error, api, options) {
reverseProxy._getAcmeApi(DOMAIN_0, function (error, api, options) {
expect(error).to.be(null);
expect(api._name).to.be('acme');
expect(options.prod).to.be(true);
@@ -202,7 +202,7 @@ describe('Certificates', function () {
});
it('returns prod acme in dev cloudron', function (done) {
reverseProxy._getCertApi(DOMAIN_0, function (error, api, options) {
reverseProxy._getAcmeApi(DOMAIN_0, function (error, api, options) {
expect(error).to.be(null);
expect(api._name).to.be('acme');
expect(options.prod).to.be(true);
@@ -224,7 +224,7 @@ describe('Certificates', function () {
after(cleanup);
it('returns staging acme in prod cloudron', function (done) {
reverseProxy._getCertApi(DOMAIN_0, function (error, api, options) {
reverseProxy._getAcmeApi(DOMAIN_0, function (error, api, options) {
expect(error).to.be(null);
expect(api._name).to.be('acme');
expect(options.prod).to.be(false);
@@ -233,7 +233,7 @@ describe('Certificates', function () {
});
it('returns staging acme in dev cloudron', function (done) {
reverseProxy._getCertApi(DOMAIN_0, function (error, api, options) {
reverseProxy._getAcmeApi(DOMAIN_0, function (error, api, options) {
expect(error).to.be(null);
expect(api._name).to.be('acme');
expect(options.prod).to.be(false);