From 1ef6eefaf6f6f49e9c8b17c753d7a97e26404f2b Mon Sep 17 00:00:00 2001 From: Girish Ramakrishnan Date: Sat, 8 Oct 2016 14:38:59 -0700 Subject: [PATCH] dns: fix noop get/upsert --- src/dns/noop.js | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/dns/noop.js b/src/dns/noop.js index d8b1da834..df594a166 100644 --- a/src/dns/noop.js +++ b/src/dns/noop.js @@ -23,7 +23,7 @@ function upsert(dnsConfig, zoneName, subdomain, type, values, callback) { debug('upsert: %s for zone %s of type %s with values %j', subdomain, zoneName, type, values); - return callback(); + return callback(null, 'noop-record-id'); } function get(dnsConfig, zoneName, subdomain, type, callback) { @@ -33,13 +33,7 @@ function get(dnsConfig, zoneName, subdomain, type, callback) { assert.strictEqual(typeof type, 'string'); assert.strictEqual(typeof callback, 'function'); - if (type !== 'A') return callback(null, [ ]); - - sysinfo.getIp(function (error, ip) { - if (error) return callback(new SubdomainError(SubdomainError.INTERNAL_ERROR, error.message)); - - return callback(null, [ ip ]); - }); + callback(null, [ ]); // returning ip confuses apptask into thinking the entry already exists } function del(dnsConfig, zoneName, subdomain, type, values, callback) {