diff --git a/src/dns/namecheap.js b/src/dns/namecheap.js index 8c114486b..d27aecf6b 100644 --- a/src/dns/namecheap.js +++ b/src/dns/namecheap.js @@ -19,7 +19,6 @@ var assert = require('assert'), safe = require('safetydance'), superagent = require('superagent'), sysinfo = require('../sysinfo.js'), - util = require('util'), waitForDns = require('./waitfordns.js'), xml2js = require('xml2js'); @@ -50,11 +49,9 @@ function getQuery(dnsConfig, callback) { }); } -function getInternal(dnsConfig, zoneName, subdomain, type, callback) { +function getZone(dnsConfig, zoneName, callback) { assert.strictEqual(typeof dnsConfig, 'object'); assert.strictEqual(typeof zoneName, 'string'); - assert.strictEqual(typeof subdomain, 'string'); - assert.strictEqual(typeof type, 'string'); assert.strictEqual(typeof callback, 'function'); getQuery(dnsConfig, function (error, query) { @@ -89,7 +86,7 @@ function getInternal(dnsConfig, zoneName, subdomain, type, callback) { }); } -function setInternal(dnsConfig, zoneName, hosts, callback) { +function setZone(dnsConfig, zoneName, hosts, callback) { assert.strictEqual(typeof dnsConfig, 'object'); assert.strictEqual(typeof zoneName, 'string'); assert(Array.isArray(hosts)); @@ -144,7 +141,7 @@ function upsert(domainObject, subdomain, type, values, callback) { assert.strictEqual(typeof domainObject, 'object'); assert.strictEqual(typeof subdomain, 'string'); assert.strictEqual(typeof type, 'string'); - assert(util.isArray(values)); + assert(Array.isArray(values)); assert.strictEqual(typeof callback, 'function'); const dnsConfig = domainObject.config; @@ -154,17 +151,17 @@ function upsert(domainObject, subdomain, type, values, callback) { debug('upsert: %s for zone %s of type %s with values %j', subdomain, zoneName, type, values); - getInternal(dnsConfig, zoneName, subdomain, type, function (error, result) { + getZone(dnsConfig, zoneName, function (error, result) { if (error) return callback(error); // Array to keep track of records that need to be inserted let toInsert = []; - for (var i = 0; i < values.length; i++) { + for (let i = 0; i < values.length; i++) { let curValue = values[i]; let wasUpdate = false; - for (var j = 0; j < result.length; j++) { + for (let j = 0; j < result.length; j++) { let curHost = result[j]; if (curHost.Type === type && curHost.Name === subdomain) { @@ -198,9 +195,9 @@ function upsert(domainObject, subdomain, type, values, callback) { } } - let toUpsert = result.concat(toInsert); + const hosts = result.concat(toInsert); - setInternal(dnsConfig, zoneName, toUpsert, callback); + setZone(dnsConfig, zoneName, hosts, callback); }); } @@ -215,16 +212,16 @@ function get(domainObject, subdomain, type, callback) { subdomain = domains.getName(domainObject, subdomain, type) || '@'; - getInternal(dnsConfig, zoneName, subdomain, type, function (error, result) { + getZone(dnsConfig, zoneName, function (error, result) { if (error) return callback(error); // We need to filter hosts to ones with this subdomain and type - let actualHosts = result.filter((host) => host.Type === type && host.Name === subdomain); + const actualHosts = result.filter((host) => host.Type === type && host.Name === subdomain); // We only return the value string - var tmp = actualHosts.map(function (record) { return record.Address; }); + const tmp = actualHosts.map(function (record) { return record.Address; }); - debug('get: %j', tmp); + debug(`get: subdomain: ${subdomain} type:${type} value:${JSON.stringify(tmp)}`); return callback(null, tmp); }); @@ -234,7 +231,7 @@ function del(domainObject, subdomain, type, values, callback) { assert.strictEqual(typeof domainObject, 'object'); assert.strictEqual(typeof subdomain, 'string'); assert.strictEqual(typeof type, 'string'); - assert(util.isArray(values)); + assert(Array.isArray(values)); assert.strictEqual(typeof callback, 'function'); const dnsConfig = domainObject.config; @@ -244,7 +241,7 @@ function del(domainObject, subdomain, type, values, callback) { debug('del: %s for zone %s of type %s with values %j', subdomain, zoneName, type, values); - getInternal(dnsConfig, zoneName, subdomain, type, function (error, result) { + getZone(dnsConfig, zoneName, function (error, result) { if (error) return callback(error); if (result.length === 0) return callback(); @@ -266,7 +263,7 @@ function del(domainObject, subdomain, type, values, callback) { } // Only set hosts if we actually removed a host - if (removed) return setInternal(dnsConfig, zoneName, result, callback); + if (removed) return setZone(dnsConfig, zoneName, result, callback); callback(); });