jjkiers/cloudron-box
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Render oidc error page instead of showing a httperror if interaction is invalid

Browse Source 
Fixes #862
This commit is contained in:
Johannes Zellner
2025-10-17 23:43:17 +02:00
parent 7d538ee1b8
commit 1bc9dc30f6
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/oidcserver.js
View File

@@ -291,9 +291,9 @@ async function renderError(error) {
return ejs.render(TEMPLATE_ERROR, data);
}
async function renderInteractionPage(req, res, next) {
async function renderInteractionPage(req, res) {
const [detailsError, details] = await safe(gOidcProvider.interactionDetails(req, res));
if (detailsError) return next(new HttpError(detailsError.statusCode, detailsError.error_description));
if (detailsError) return res.send(await renderError(new Error('Invalid session')));
const { uid, prompt, params, session } = details;
@@ -409,7 +409,8 @@ async function interactionLogin(req, res, next) {
}
async function interactionConfirm(req, res, next) {
const interactionDetails = await gOidcProvider.interactionDetails(req, res);
const [detailsError, interactionDetails] = await safe(gOidcProvider.interactionDetails(req, res));
if (detailsError) return next(new HttpError(detailsError.statusCode, detailsError.error_description));
const { grantId, uid, prompt: { name, details }, params, session: { accountId }, lastSubmission } = interactionDetails;
debug(`route interaction confirm post uid:${uid} prompt.name:${name} accountId:${accountId}`);