jjkiers/cloudron-box
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Do not use $index with angular sorted lists

Browse Source
This commit is contained in:
Johannes Zellner
2022-02-23 17:02:45 +01:00
parent 50f9624f4a
commit 10c0679d8f
2 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/views/email.html
+1 -1
View File
@@ -141,7 +141,7 @@
</div> </div>
</div> </div>
<div class="col col-lg-1"> <div class="col col-lg-1">
<button class="btn btn-danger btn-sm" ng-click="mailboxes.edit.delAlias($event, $index)"><i class="far fa-trash-alt"></i></button> <button class="btn btn-danger btn-sm" ng-click="mailboxes.edit.delAlias($event, alias)"><i class="far fa-trash-alt"></i></button>
</div> </div>
</div> </div>
<div ng-show="mailboxes.edit.aliases.length === 0"> <div ng-show="mailboxes.edit.aliases.length === 0">
src/views/email.js
+5 -1
View File
@@ -586,8 +586,12 @@ angular.module('Application').controller('EmailController', ['$scope', '$locatio
}); });
}, },
delAlias: function (event, index) { delAlias: function (event, alias) {
event.preventDefault(); event.preventDefault();
var index = $scope.mailboxes.edit.aliases.findIndex(function (a) { return (a.name+a.domain) === (alias.name+alias.domain); });
if (index === -1) return;
$scope.mailboxes.edit.aliases.splice(index, 1); $scope.mailboxes.edit.aliases.splice(index, 1);
}, },