jjkiers/cloudron-box
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Remove bindDn validation

Browse Source 
in some AD setups, this is a email
This commit is contained in:
Girish Ramakrishnan
2019-10-30 09:35:30 -07:00
parent 59deca76a1
commit 0a695190c4
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/externalldap.js
+1 -1
View File
@@ -40,7 +40,6 @@ function getClient(externalLdapConfig, callback) {
// basic validation to not crash
try { ldap.parseDN(externalLdapConfig.baseDn); } catch (e) { return callback(new BoxError(BoxError.BAD_FIELD, 'invalid baseDn')); }
try { ldap.parseFilter(externalLdapConfig.filter); } catch (e) { return callback(new BoxError(BoxError.BAD_FIELD, 'invalid filter')); }
if (externalLdapConfig.bindDn) try { ldap.parseFilter(externalLdapConfig.bindDn); } catch (e) { return callback(new BoxError(BoxError.INVALID_CREDENTIALS)); }
var client;
try {
@@ -70,6 +69,7 @@ function testConfig(config, callback) {
if (!config.baseDn) return callback(new BoxError(BoxError.BAD_FIELD, 'basedn must not be empty'));
if (!config.filter) return callback(new BoxError(BoxError.BAD_FIELD, 'filter must not be empty'));
if (!config.usernameField) config.usernameField = 'uid';
// bindDn may not be a dn!
getClient(config, function (error, client) {
if (error) return callback(error);