jjkiers/cloudron-box
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

namecheap: fix del

Browse Source
This commit is contained in:
Girish Ramakrishnan
2021-04-13 22:27:38 -07:00
parent 564409d8b7
commit 0712eb1250
1 changed files with 4 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/dns/namecheap.js
+4 -14
View File
@@ -249,25 +249,15 @@ function del(domainObject, subdomain, type, values, callback) {
if (error) return callback(error); if (error) return callback(error);
if (result.length === 0) return callback(); if (result.length === 0) return callback();
const originalLength = result.length;
let removed = false; for (let i = 0; i < values.length; i++) {
for (var i = 0; i < values.length; i++) {
let curValue = values[i]; let curValue = values[i];
for (var j = 0; j < result.length; j++) { result = result.filter(curHost => curHost.Type !== type || curHost.Name !== subdomain || curHost.Address !== curValue);
let curHost = result[i];
if (curHost.Type === type && curHost.Name === subdomain && curHost.Address === curValue) {
removed = true;
result.splice(i, 1); // Remove element from result array
}
}
} }
// Only set hosts if we actually removed a host if (result.length !== originalLength) return setZone(dnsConfig, zoneName, result, callback);
if (removed) return setZone(dnsConfig, zoneName, result, callback);
callback(); callback();
}); });