domains: remove SECRET_PLACEHOLDER from responses

src/dns/gcdns.js

@@ -1,17 +1,5 @@
 'use strict';
 
-const safe = require('safetydance');
-
-exports = module.exports = {
-    removePrivateFields,
-    injectPrivateFields,
-    upsert,
-    get,
-    del,
-    wait,
-    verifyDomainConfig
-};
-
 const assert = require('node:assert'),
     BoxError = require('../boxerror.js'),
     constants = require('../constants.js'),
@@ -19,16 +7,17 @@ const assert = require('node:assert'),
     dig = require('../dig.js'),
     dns = require('../dns.js'),
     GCDNS = require('@google-cloud/dns').DNS,
+    safe = require('safetydance'),
     waitForDns = require('./waitfordns.js'),
     _ = require('../underscore.js');
 
 function removePrivateFields(domainObject) {
-    domainObject.config.credentials.private_key = constants.SECRET_PLACEHOLDER;
+    delete domainObject.config.credentials.private_key;
     return domainObject;
 }
 
 function injectPrivateFields(newConfig, currentConfig) {
-    if (newConfig.credentials.private_key === constants.SECRET_PLACEHOLDER && currentConfig.credentials) newConfig.credentials.private_key = currentConfig.credentials.private_key;
+    if (!Object.hasOwn(newConfig.credentials, 'private_key') && currentConfig.credentials) newConfig.credentials.private_key = currentConfig.credentials.private_key;
 }
 
 function getDnsCredentials(domainConfig) {
@@ -193,3 +182,13 @@ async function verifyDomainConfig(domainObject) {
 
     return credentials;
 }
+
+exports = module.exports = {
+    removePrivateFields,
+    injectPrivateFields,
+    upsert,
+    get,
+    del,
+    wait,
+    verifyDomainConfig
+};