constness

This commit is contained in:
Girish Ramakrishnan
2022-04-14 17:41:41 -05:00
parent 05d7a7f496
commit 01ce251596
5 changed files with 87 additions and 87 deletions

View File

@@ -67,9 +67,9 @@ describe('Storage', function () {
});
it('can upload', function (done) {
var sourceFile = path.join(__dirname, 'storage/data/test.txt');
var sourceStream = fs.createReadStream(sourceFile);
var destFile = gTmpFolder + '/uploadtest/test.txt';
const sourceFile = path.join(__dirname, 'storage/data/test.txt');
const sourceStream = fs.createReadStream(sourceFile);
const destFile = gTmpFolder + '/uploadtest/test.txt';
filesystem.upload(gBackupConfig, destFile, sourceStream, function (error) {
expect(error).to.be(null);
expect(fs.existsSync(destFile));
@@ -79,9 +79,9 @@ describe('Storage', function () {
});
it('upload waits for empty file to be created', function (done) {
var sourceFile = path.join(__dirname, 'storage/data/empty');
var sourceStream = fs.createReadStream(sourceFile);
var destFile = gTmpFolder + '/uploadtest/empty';
const sourceFile = path.join(__dirname, 'storage/data/empty');
const sourceStream = fs.createReadStream(sourceFile);
const destFile = gTmpFolder + '/uploadtest/empty';
filesystem.upload(gBackupConfig, destFile, sourceStream, function (error) {
expect(error).to.be(null);
expect(fs.existsSync(destFile));
@@ -91,10 +91,10 @@ describe('Storage', function () {
});
it('upload unlinks old file', function (done) {
var sourceFile = path.join(__dirname, 'storage/data/test.txt');
var sourceStream = fs.createReadStream(sourceFile);
var destFile = gTmpFolder + '/uploadtest/test.txt';
var oldStat = fs.statSync(destFile);
const sourceFile = path.join(__dirname, 'storage/data/test.txt');
const sourceStream = fs.createReadStream(sourceFile);
const destFile = gTmpFolder + '/uploadtest/test.txt';
const oldStat = fs.statSync(destFile);
filesystem.upload(gBackupConfig, destFile, sourceStream, function (error) {
expect(error).to.be(null);
expect(fs.existsSync(destFile)).to.be(true);
@@ -105,7 +105,7 @@ describe('Storage', function () {
});
it('can download file', function (done) {
var sourceFile = gTmpFolder + '/uploadtest/test.txt';
const sourceFile = gTmpFolder + '/uploadtest/test.txt';
filesystem.download(gBackupConfig, sourceFile, function (error, stream) {
expect(error).to.be(null);
@@ -115,7 +115,7 @@ describe('Storage', function () {
});
it('download errors for missing file', function (done) {
var sourceFile = gTmpFolder + '/uploadtest/missing';
const sourceFile = gTmpFolder + '/uploadtest/missing';
filesystem.download(gBackupConfig, sourceFile, function (error) {
expect(error.reason).to.be(BoxError.NOT_FOUND);
@@ -124,14 +124,14 @@ describe('Storage', function () {
});
it('list dir lists the source dir', function (done) {
var sourceDir = path.join(__dirname, 'storage');
const sourceDir = path.join(__dirname, 'storage');
var allFiles = [ ];
let allFiles = [ ];
filesystem.listDir(gBackupConfig, sourceDir, 1, function (files, iteratorCallback) {
allFiles = allFiles.concat(files);
iteratorCallback();
}, function () {
var expectedFiles = execSync(`find ${sourceDir} -type f`, { encoding: 'utf8' }).trim().split('\n');
const expectedFiles = execSync(`find ${sourceDir} -type f`, { encoding: 'utf8' }).trim().split('\n');
expect(allFiles.map(function (f) { return f.fullPath; }).sort()).to.eql(expectedFiles.sort());
done();
@@ -139,10 +139,10 @@ describe('Storage', function () {
});
it('can copy', function (done) {
var sourceFile = gTmpFolder + '/uploadtest/test.txt'; // keep the test within save device
var destFile = gTmpFolder + '/uploadtest/test-hardlink.txt';
const sourceFile = gTmpFolder + '/uploadtest/test.txt'; // keep the test within save device
const destFile = gTmpFolder + '/uploadtest/test-hardlink.txt';
var events = filesystem.copy(gBackupConfig, sourceFile, destFile);
const events = filesystem.copy(gBackupConfig, sourceFile, destFile);
events.on('done', function (error) {
expect(error).to.be(null);
expect(fs.statSync(destFile).nlink).to.be(2); // created a hardlink
@@ -151,7 +151,7 @@ describe('Storage', function () {
});
it('can remove file', function (done) {
var sourceFile = gTmpFolder + '/uploadtest/test-hardlink.txt';
const sourceFile = gTmpFolder + '/uploadtest/test-hardlink.txt';
filesystem.remove(gBackupConfig, sourceFile, function (error) {
expect(error).to.be(null);
@@ -161,7 +161,7 @@ describe('Storage', function () {
});
it('can remove empty dir', function (done) {
var sourceDir = gTmpFolder + '/emptydir';
const sourceDir = gTmpFolder + '/emptydir';
fs.mkdirSync(sourceDir);
filesystem.remove(gBackupConfig, sourceDir, function (error) {
@@ -173,7 +173,7 @@ describe('Storage', function () {
});
describe('noop', function () {
var gBackupConfig = {
const gBackupConfig = {
provider: 'noop',
format: 'tgz'
};
@@ -199,7 +199,7 @@ describe('Storage', function () {
});
it('can copy', function (done) {
var events = noop.copy(gBackupConfig, 'sourceFile', 'destFile');
const events = noop.copy(gBackupConfig, 'sourceFile', 'destFile');
events.on('done', function (error) {
expect(error).to.be(null);
done();
@@ -222,8 +222,8 @@ describe('Storage', function () {
});
describe('s3', function () {
var gS3Folder;
var gBackupConfig = {
let gS3Folder;
const gBackupConfig = {
provider: 's3',
key: 'key',
prefix: 'unit.test',
@@ -248,9 +248,9 @@ describe('Storage', function () {
});
it('can upload', function (done) {
var sourceFile = path.join(__dirname, 'storage/data/test.txt');
var sourceStream = fs.createReadStream(sourceFile);
var destKey = 'uploadtest/test.txt';
const sourceFile = path.join(__dirname, 'storage/data/test.txt');
const sourceStream = fs.createReadStream(sourceFile);
const destKey = 'uploadtest/test.txt';
s3.upload(gBackupConfig, destKey, sourceStream, function (error) {
expect(error).to.be(null);
expect(fs.existsSync(path.join(gS3Folder, destKey))).to.be(true);
@@ -260,7 +260,7 @@ describe('Storage', function () {
});
it('can download file', function (done) {
var sourceKey = 'uploadtest/test.txt';
const sourceKey = 'uploadtest/test.txt';
s3.download(gBackupConfig, sourceKey, function (error, stream) {
expect(error).to.be(null);
expect(stream).to.be.an('object');
@@ -269,7 +269,7 @@ describe('Storage', function () {
});
it('list dir lists contents of source dir', function (done) {
var allFiles = [ ];
let allFiles = [ ];
s3.listDir(gBackupConfig, '', 1, function (files, iteratorCallback) {
allFiles = allFiles.concat(files);
iteratorCallback();
@@ -283,11 +283,11 @@ describe('Storage', function () {
it('can copy', function (done) {
fs.writeFileSync(path.join(gS3Folder, 'uploadtest/C++.gitignore'), 'special', 'utf8');
var sourceKey = 'uploadtest';
const sourceKey = 'uploadtest';
var events = s3.copy(gBackupConfig, sourceKey, 'uploadtest-copy');
const events = s3.copy(gBackupConfig, sourceKey, 'uploadtest-copy');
events.on('done', function (error) {
var sourceFile = path.join(__dirname, 'storage/data/test.txt');
const sourceFile = path.join(__dirname, 'storage/data/test.txt');
expect(error).to.be(null);
expect(fs.statSync(path.join(gS3Folder, 'uploadtest-copy/test.txt')).size).to.be(fs.statSync(sourceFile).size);
@@ -314,7 +314,7 @@ describe('Storage', function () {
});
describe('gcs', function () {
var gBackupConfig = {
const gBackupConfig = {
provider: 'gcs',
key: '',
prefix: 'unit.test',
@@ -325,14 +325,14 @@ describe('Storage', function () {
private_key: ''
}
};
var GCSMockBasePath = path.join(os.tmpdir(), 'gcs-backup-test-buckets/');
const GCSMockBasePath = path.join(os.tmpdir(), 'gcs-backup-test-buckets/');
before(function () {
var mockGCS = function(){
const mockGCS = function(){
return {bucket: function(){
var file = function(filename){
const file = function(filename){
var ensurePathWritable = function (filename) {
const ensurePathWritable = function (filename) {
filename = GCSMockBasePath + filename;
fs.mkdirSync(path.dirname(filename), { recursive: true });
return filename;
@@ -356,7 +356,7 @@ describe('Storage', function () {
fs.unlink(ensurePathWritable(filename), cb);
},
copy: function(dst, cb){
var notFoundHandler = function(e){
const notFoundHandler = function(e){
if (e && e.code == 'ENOENT') { e.code = 404; return cb(e);}
cb();
};
@@ -374,15 +374,15 @@ describe('Storage', function () {
return {
file: file,
getFiles: function(q, cb){
var target = GCSMockBasePath + q.prefix;
const target = GCSMockBasePath + q.prefix;
recursive_readdir(target, function(e, files){
var pageToken = q.pageToken || 0;
const pageToken = q.pageToken || 0;
var chunkedFiles = chunk(files, q.maxResults);
const chunkedFiles = chunk(files, q.maxResults);
if (q.pageToken >= chunkedFiles.length) return cb(null, []);
var gFiles = chunkedFiles[pageToken].map(function(f){
const gFiles = chunkedFiles[pageToken].map(function(f){
return file(path.relative(GCSMockBasePath, f)); //convert to google
});
@@ -403,9 +403,9 @@ describe('Storage', function () {
});
it('can backup', function (done) {
var sourceFile = path.join(__dirname, 'storage/data/test.txt');
var sourceStream = fs.createReadStream(sourceFile);
var destKey = 'uploadtest/test.txt';
const sourceFile = path.join(__dirname, 'storage/data/test.txt');
const sourceStream = fs.createReadStream(sourceFile);
const destKey = 'uploadtest/test.txt';
gcs.upload(gBackupConfig, destKey, sourceStream, function (error) {
expect(error).to.be(null);
@@ -414,7 +414,7 @@ describe('Storage', function () {
});
it('can download file', function (done) {
var sourceKey = 'uploadtest/test.txt';
const sourceKey = 'uploadtest/test.txt';
gcs.download(gBackupConfig, sourceKey, function (error, stream) {
expect(error).to.be(null);
expect(stream).to.be.an('object');
@@ -423,7 +423,7 @@ describe('Storage', function () {
});
it('list dir lists contents of source dir', function (done) {
var allFiles = [ ];
let allFiles = [ ];
gcs.listDir(gBackupConfig, '', 1, function (files, iteratorCallback) {
allFiles = allFiles.concat(files);
iteratorCallback();
@@ -437,11 +437,11 @@ describe('Storage', function () {
xit('can copy', function (done) {
fs.writeFileSync(path.join(GCSMockBasePath, 'uploadtest/C++.gitignore'), 'special', 'utf8');
var sourceKey = 'uploadtest';
const sourceKey = 'uploadtest';
var events = gcs.copy(gBackupConfig, sourceKey, 'uploadtest-copy');
const events = gcs.copy(gBackupConfig, sourceKey, 'uploadtest-copy');
events.on('done', function (error) {
var sourceFile = path.join(__dirname, 'storage/data/test.txt');
const sourceFile = path.join(__dirname, 'storage/data/test.txt');
expect(error).to.be(null);
expect(fs.statSync(path.join(GCSMockBasePath, 'uploadtest-copy/test.txt')).size).to.be(fs.statSync(sourceFile).size);