constness

src/test/externalldap-test.js

@@ -40,10 +40,10 @@ const LDAP_CONFIG = {
 
 // helper function to deal with pagination taken from ldap.js
 function finalSend(results, req, res, next) {
-    var min = 0;
-    var max = results.length;
-    var cookie = null;
-    var pageSize = 0;
+    let min = 0;
+    const max = results.length;
+    let cookie = null;
+    let pageSize = 0;
 
     // check if this is a paging request, if so get the cookie for session info
     req.controls.forEach(function (control) {
@@ -56,7 +56,7 @@ function finalSend(results, req, res, next) {
     function sendPagedResults(start, end) {
         start = (start < min) ? min : start;
         end = (end > max || end < min) ? max : end;
-        var i;
+        let i;
 
         for (i = start; i < end; i++) {
             res.send(results[i]);
@@ -67,13 +67,13 @@ function finalSend(results, req, res, next) {
 
     if (cookie && Buffer.isBuffer(cookie)) {
         // we have pagination
-        var first = min;
+        let first = min;
         if (cookie.length !== 0) {
             first = parseInt(cookie.toString(), 10);
         }
-        var last = sendPagedResults(first, first + pageSize);
+        const last = sendPagedResults(first, first + pageSize);
 
-        var resultCookie;
+        let resultCookie;
         if (last < max) {
             resultCookie = Buffer.from(last.toString());
         } else {
@@ -108,9 +108,9 @@ function startLdapServer(callback) {
         let results = [];
 
         gLdapUsers.forEach(function (entry) {
-            var dn = ldap.parseDN(`cn=${entry.username},${LDAP_BASE_DN}`);
+            const dn = ldap.parseDN(`cn=${entry.username},${LDAP_BASE_DN}`);
 
-            var obj = {
+            const obj = {
                 dn: dn.toString(),
                 attributes: {
                     objectclass: [ 'inetOrgPerson' ],
@@ -133,9 +133,9 @@ function startLdapServer(callback) {
         let results = [];
 
         gLdapGroups.forEach(function (entry) {
-            var dn = ldap.parseDN(`cn=${entry.groupname},${LDAP_GROUP_BASE_DN}`);
+            const dn = ldap.parseDN(`cn=${entry.groupname},${LDAP_GROUP_BASE_DN}`);
 
-            var obj = {
+            const obj = {
                 dn: dn.toString(),
                 attributes: {
                     objectclass: [ 'groupOfNames' ],
@@ -156,8 +156,8 @@ function startLdapServer(callback) {
 
     gLdapServer.bind(LDAP_BASE_DN, function (req, res, next) {
         // extract the common name which might have different attribute names
-        var attributeName = Object.keys(req.dn.rdns[0].attrs)[0];
-        var commonName = req.dn.rdns[0].attrs[attributeName].value;
+        const attributeName = Object.keys(req.dn.rdns[0].attrs)[0];
+        const commonName = req.dn.rdns[0].attrs[attributeName].value;
         if (!commonName) return next(new ldap.NoSuchObjectError(req.dn.toString()));
 
         if (!gLdapUsers.find(function (u) { return u.username === commonName; })) return next(new ldap.NoSuchObjectError(req.dn.toString()));
@@ -175,7 +175,7 @@ function stopLdapServer(callback) {
 }
 
 describe('External LDAP', function () {
-    const { setup, cleanup, admin, serverUrl, auditSource } = common;
+    const { setup, cleanup, admin, serverUrl } = common;
 
     before(function (done) {
         async.series([