jjkiers/banks2ff
1
0
Fork 0
Code Issues Pull Requests Actions Packages Releases Activity

feat: Add CLI table formatting and remove unused inspection methods

Browse Source 
- Enhanced CLI output with table formatting for better readability of account and transaction data
- Added new commands to list accounts and view their sync status
- Added new commands to inspect transaction information and cache status
- Cleaned up internal code by removing unused trait methods and implementations
- Updated documentation with examples of new CLI commands

This improves the user experience with clearer CLI output and new inspection capabilities while maintaining code quality.
This commit is contained in:
Jacob Kiers
2025-11-22 18:54:53 +00:00
parent b85c366176
commit baac50c36a
12 changed files with 450 additions and 247 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
specs/cli-refactor-plan.md
View File

@@ -131,19 +131,19 @@ COMMANDS:
- Added CLI commands under `banks2ff accounts link` with full CRUD operations and alias support
- Updated README with new account linking feature, examples, and troubleshooting
### Phase 4: CLI Output and Formatting
### Phase 4: CLI Output and Formatting ✅ COMPLETED
**Objective**: Implement user-friendly output for inspection commands.
**Steps:**
1. Create `cli::formatters` module for consistent output formatting
2. Implement table-based display for accounts and transactions
3. Add JSON output option for programmatic use
4. Ensure sensitive data masking in all outputs
5. Add progress indicators for long-running operations
6. Implement `accounts` command with `list` and `status` subcommands
7. Implement `transactions` command with `list`, `cache-status`, and `clear-cache` subcommands
8. Add account and transaction inspection methods to adapter traits
1. ✅ Create `cli::formatters` module for consistent output formatting
2. ✅ Implement table-based display for accounts and transactions
3. ✅ Add JSON output option for programmatic use
4. ✅ Ensure sensitive data masking in all outputs
5. Add progress indicators for long-running operations (pending)
6. ✅ Implement `accounts` command with `list` and `status` subcommands
7. ✅ Implement `transactions` command with `list`, `cache-status`, and `clear-cache` subcommands
8. ✅ Add account and transaction inspection methods to adapter traits
**Testing:**
- Unit tests for formatter functions
@@ -152,6 +152,14 @@ COMMANDS:
- Unit tests for new command implementations
- Integration tests for account/transaction inspection
**Implementation Details:**
- Created `cli::formatters` module with `Formattable` trait and table formatting using `comfy-table`
- Implemented table display for `AccountSummary`, `AccountStatus`, `TransactionInfo`, and `CacheInfo` structs
- Added IBAN masking (showing only last 4 characters) for privacy
- Updated CLI structure with new `accounts` and `transactions` commands
- Added `print_list_output` function for displaying collections of data
- All code formatted with `cargo fmt` and linted with `cargo clippy`
### Phase 5: Status and Cache Management
**Objective**: Implement status overview and cache management commands.