jjkiers/banks2ff
1
0
Fork 0
Code Issues Pull Requests Actions Packages Releases Activity

Fix bug in official Gocardless API definition

Browse Source 
The official Gocardless API definition indicates that transactions are
directly output to an array.

Instead, they are wrapped in a transactions key.

This made the code fail to retrieve transactions, because they could not
be correctly serialized.

This is now fixed in the API definition, and the API code is also
regenerated.

Signed-off-by: Jacob Kiers <code@kiers.eu>
This commit is contained in:
Jacob Kiers
2024-10-04 20:34:27 +02:00
parent f0b8df90b9
commit 80849a9eef
8 changed files with 71 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
gocardless_bank_account_data_api_v2.json
View File

@@ -396,8 +396,8 @@
"AccountStateError": {
"value": {
"id": "3fa85f64-5717-4562-b3fc-2c963f66afa6",
"created": "2024-10-04 18:06:13.681544+00:00",
"last_accessed": "2024-10-04 18:06:13.681558+00:00",
"created": "2024-10-04 17:15:14.926423+00:00",
"last_accessed": "2024-10-04 17:15:14.926442+00:00",
"iban": "string",
"aspsp_identifier": "string",
"status": "ERROR"
@@ -703,8 +703,8 @@
"AccountStateError": {
"value": {
"id": "3fa85f64-5717-4562-b3fc-2c963f66afa6",
"created": "2024-10-04 18:06:13.681544+00:00",
"last_accessed": "2024-10-04 18:06:13.681558+00:00",
"created": "2024-10-04 17:15:14.926423+00:00",
"last_accessed": "2024-10-04 17:15:14.926442+00:00",
"iban": "string",
"aspsp_identifier": "string",
"status": "ERROR"
@@ -804,7 +804,7 @@
"content": {
"application/json": {
"schema": {
"$ref": "#/components/schemas/BankTransaction"
"$ref": "#/components/schemas/BankTransactions"
},
"examples": {
"RetrieveAccountTransactions": {
@@ -1080,8 +1080,8 @@
"AccountStateError": {
"value": {
"id": "3fa85f64-5717-4562-b3fc-2c963f66afa6",
"created": "2024-10-04 18:06:13.681544+00:00",
"last_accessed": "2024-10-04 18:06:13.681558+00:00",
"created": "2024-10-04 17:15:14.926423+00:00",
"last_accessed": "2024-10-04 17:15:14.926442+00:00",
"iban": "string",
"aspsp_identifier": "string",
"status": "ERROR"
@@ -1329,7 +1329,7 @@
},
{
"summary": "Unsupported access scope selected.",
"detail": "The access scopes supported by the institution are ['transactions']. The following scopes are not supported: ['details', 'balances']"
"detail": "The access scopes supported by the institution are ['transactions']. The following scopes are not supported: ['balances', 'details']"
},
{
"summary": "Field 'access_scope' may not be an empty list.",
@@ -3684,6 +3684,20 @@
"balanceType"
]
},
"BankTransactions": {
"type": "object",
"description": "BankTransactions.",
"properties": {
"transactions": {
"allOf": [
{
"$ref": "#/components/schemas/BankTransaction"
}
],
"description": "BankTransaction"
}
}
},
"BankTransaction": {
"type": "object",
"description": "BankTransactionSerializer.",