From 3099dcf617cb24777f1dd7d187c3caa893dcad01 Mon Sep 17 00:00:00 2001 From: Jacob Kiers Date: Fri, 2 Oct 2015 15:34:34 +0200 Subject: [PATCH 1/2] Maintain compatibility for PHP 5.3.0 - 5.3.8 Interface inheritance is not possible before PHP 5.3.9. That is an artefact of PHP bug 43200 (https://bugs.php.net/43200). Since the composer.json states that the PHP versions >= 5.3.0 are supported, we have to maintain compatibility with PHP 5.3.X. Fixes: #7 Signed-off-by: Jacob Kiers --- .../OAuth/SignatureMethod/SignatureMethod.php | 22 ------------------- 1 file changed, 22 deletions(-) diff --git a/src/JacobKiers/OAuth/SignatureMethod/SignatureMethod.php b/src/JacobKiers/OAuth/SignatureMethod/SignatureMethod.php index 067b5d1..74a833b 100644 --- a/src/JacobKiers/OAuth/SignatureMethod/SignatureMethod.php +++ b/src/JacobKiers/OAuth/SignatureMethod/SignatureMethod.php @@ -27,28 +27,6 @@ use \JacobKiers\OAuth\Request\RequestInterface; */ abstract class SignatureMethod implements SignatureMethodInterface { - /** - * Return the name of the Signature Method (ie HMAC-SHA1). - * - * @return string - */ - abstract public function getName(); - - /** - * Build up the signature. - * - * NOTE: The output of this function MUST NOT be urlencoded. - * the encoding is handled in OAuthRequest when the final - * request is serialized. - * - * @param JacobKiers\OAuth\Request\RequestInterface $request - * @param JacobKiers\OAuth\Consumer\ConsumerInterface $consumer - * @param JacobKiers\OAuth\Token\TokenInterface $token - * - * @return string - */ - abstract public function buildSignature(RequestInterface $request, ConsumerInterface $consumer, TokenInterface $token = null); - /** * Get the signature key, made up of consumer and optionally token shared secrets. * -- 2.34.1 From e507a5dc8b35be372b7990068c0636df68a62924 Mon Sep 17 00:00:00 2001 From: Jacob Kiers Date: Fri, 2 Oct 2015 15:40:13 +0200 Subject: [PATCH 2/2] Update travis configuration Test more PHP versions, in order to maintain compatibility. Also updates the composer install command. Signed-off-by: Jacob Kiers --- .travis.yml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 434d1af..1f2cff1 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,9 +1,15 @@ +sudo: false + language: php php: + - 5.3 - 5.4 - 5.5 + - 5.6 + - 7 + - hhvm before_script: - composer selfupdate --quiet - - composer install --dev + - composer install --prefer-dist - vendor/phpunit/phpunit/composer/bin/phpunit -- 2.34.1