Commit Graph

74 Commits

Author SHA1 Message Date
e4e8bc2f90 Merge remote-tracking branch 'vb/master' 2013-11-19 21:03:00 +01:00
victorbjelkholm
4011b3674d Throwing OAuthException without oauth_consumer_key 2013-11-19 20:58:34 +01:00
victorbjelkholm
fdb6c2df49 Update travis.yml 2013-11-19 20:57:18 +01:00
victorbjelkholm
da8c3c46c5 Remove parameter should be passed reference 2013-11-19 20:54:56 +01:00
victorbjelkholm
cec7f31cda Change colors=false to colors=true 2013-11-19 20:54:56 +01:00
ca5c3596dc Added .gitattributes
Signed-off-by: Jacob Kiers <jacob@jacobkiers.net>
2013-08-15 19:59:33 +02:00
b3d4f9b6bc Added CONTRIBUTORS.md file.
Signed-off-by: Jacob Kiers <jacob@jacobkiers.net>
2013-06-06 05:58:53 +02:00
Alexandru G
087cb1278f Because $token refs an object, this statement will always be true. Therefore an empty oauth_token param will be added to each request, wich will break Bitbucket authorization process.
To fix this, we need to check if token key is empty and ignore it.
2013-06-06 05:58:53 +02:00
Jacob Kiers
6677c1da7d The output of Server::verifyToken is now a hash. 2013-02-15 12:09:56 +00:00
097b0af7b4 Merge pull request #1 from jacobkiers/feature/use-interfaces
Use Interfaces everywhere.
2013-02-11 06:29:16 -08:00
Jacob Kiers
8bd355f556 Use Interfaces anywhere.
In practice, there were still too many concrete classes, which makes
integration into a framework hard. To overcome this, the codebase has
been refactored to use Interfaces when a resource is needed.

All necessary Interfaces have been created, and the existing concrete
classes now implement these interfaces.
2013-02-11 14:02:14 +00:00
Jacob Kiers
4e6cc6c811 Bugfix in Server and CS Fixes. 2013-02-11 09:30:45 +00:00
Jacob Kiers
73c99e3652 Fix SignatureMethodTest to use RequestInterface. 2013-02-08 15:28:03 +00:00
Jacob Kiers
646e466639 Also use RequestInterface in Signature Methods. 2013-02-08 15:26:42 +00:00
Jacob Kiers
e8edc17196 Have the Server use RequestInterface. 2013-02-08 15:14:38 +00:00
Jacob Kiers
74fd426e45 Also build against PHP 5.5.
But a failing build agains PHP 5.5 should not fail the whole build.
2013-02-08 11:09:37 +00:00
Jacob Kiers
be09ba0216 Added RequestInterface to make integration easier.
Since now only a RequestInterface is needed instead of a Request object,
it becomes easier to use the Server component with a different Request
object, such as the Symfony or Zend Framework Request objects.

This will now only need a small wrapper, instead of extending and
rewriting the existing Request object.
2013-02-08 10:57:53 +00:00
Jacob Kiers
c471cd2b8d Renamed DataStore to DataStoreInterface
Also, the Interface now contains comments on the expected return values.
2013-02-08 10:37:21 +00:00
Jacob Kiers
204ec8b42f Renamed namespace to JacobKiers 2013-02-08 10:32:26 +00:00
Jacob Kiers
81a1af738b Update information so the fork won't create issues
Just some updates to the Composer and Travis configuration and the
LICENSE file.
2013-02-06 22:39:13 +00:00
GaryJones
354f31fd6d Stop emails from Travis notifications. 2012-12-04 02:12:35 +00:00
GaryJones
49ecd40ba5 Undo travis config simplification, as tests have now passed in the meantime. 2012-12-04 02:07:00 +00:00
GaryJones
a404154b2c Simplify Travis config file to get it working. 2012-12-04 02:02:40 +00:00
GaryJones
2890e3cd33 Add Travis build status image to readme. 2012-12-04 01:58:08 +00:00
GaryJones
d5b23e95bb Update gitignore file 2012-12-04 01:28:58 +00:00
GaryJones
391a3f2a91 Add travis config file 2012-12-04 01:28:30 +00:00
GaryJones
87a4b17394 Refactor common code for getting the signature key. 2012-11-23 12:30:38 +00:00
GaryJones
a5ba220ae1 Add tests for concrete method inside abstract SignatureMethod class. 2012-11-23 12:22:04 +00:00
GaryJones
7457f612b7 Add test for NullToken. 2012-11-23 12:20:23 +00:00
GaryJones
d94446782a Rename OAuth\Exception back to OAuthException, to follow the standard PHP way of naming predefined / SPL exceptions. 2012-11-22 18:11:12 +00:00
GaryJones
f8be34b748 Typo 2012-11-22 17:47:43 +00:00
GaryJones
fce57a4e6e Add new NullToken, to satisfy type hint checks when token would otherwise not be set. 2012-11-22 17:37:12 +00:00
GaryJones
af1993ac3a Make the Token arg of buildSignature() methods optional.
RSA-SHA1 buildSignature() doesn't use it at all, and the other two allow for there to be no token, as on the initial client request. The token shared-secret as taken to be an empty string.
2012-11-22 16:27:47 +00:00
GaryJones
bfabd20ae4 Fix bug where the colon between host and port would appear, even when port was an empty string. 2012-11-22 16:25:34 +00:00
GaryJones
52d9317cfd Add unit tests for signature methods, and a couple for Request. 2012-11-22 16:24:21 +00:00
GaryJones
b564cbd103 Change line endings...again :-/ 2012-11-22 13:24:15 +00:00
GaryJones
1f05207957 Add basic client and token unit tests. 2012-11-22 13:18:56 +00:00
GaryJones
7ef4283511 Limit phpunit dev dependency to stable. 2012-11-22 13:18:34 +00:00
GaryJones
a58bceb4aa Make callback_url property protected, and add get/set methods. 2012-11-22 13:17:23 +00:00
GaryJones
b06d99ccbf Everything documented, including clearer author attribution.
Renamed a few classes to rely more on OAuth namespace, instead of OAuth class prefix.
2012-11-21 11:10:57 +00:00
GaryJones
92cd49d385 Clarify license as MIT.
Include a LICENSE file, giving original work copyright to Andy Smith, and modifications by Gary Jones.
2012-11-19 17:55:49 +00:00
Gary Jones
e233a83f43 Add current status note to readme. 2012-11-18 12:29:31 +00:00
Gary Jones
e8cd1bdc22 Add phpunit.xml config file. 2012-11-18 12:28:10 +00:00
Gary Jones
68dcff84a4 Add some require-dev dependencies. 2012-11-18 12:27:26 +00:00
Gary Jones
12afd40c6e Change all references to consumer to client, as per RFC 5849. 2012-11-18 02:33:29 +00:00
Gary Jones
4d5cfee737 Add trailing slash to PSR-0 value. 2012-11-18 01:40:40 +00:00
Gary Jones
abe9e182cb Fix incorrect namespace. 2012-11-18 01:33:27 +00:00
Gary Jones
36add4e946 Use single quotes for simple strings. 2012-11-18 01:32:38 +00:00
Gary Jones
bebf65bfed Fix issue for PHP 5.4.8 where the host part from parse_url seems to also include the port as well. 2012-11-18 01:18:11 +00:00
Gary Jones
dc7230cbb4 Fix old array_map() reference. 2012-11-17 23:14:25 +00:00